Changing validator group voting gold #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2171 +/- ##
========================================
Coverage 74.88% 74.88%
========================================
Files 279 279
Lines 7797 7797
Branches 971 690 -281
========================================
Hits 5839 5839
Misses 1842 1842
Partials 116 116
Continue to review full report at Codecov.
|
asaj
reviewed
Dec 11, 2019
There was a problem hiding this comment.
Can you create an issue to remove the previous logic?
Also please have @timmoreton take a look as he was the one who wrote that logic initially and may have other ideas about how this should be done
lucasege
force-pushed
the
lucasege/lowering-celo-validator-voting
branch
from
2552573
to
bee19c2
Compare
timmoreton
approved these changes
Dec 11, 2019
added 5 commits
December 11, 2019 14:08
lucasege
force-pushed
the
lucasege/lowering-celo-validator-voting
branch
from
415c833
to
47cf711
Compare
aaronmgdr
added a commit
that referenced
this pull request
Dec 12, 2019
* master: Add /test_attestations endpoint on the attestation service (#2189) Overhaul readme (#2201) Dont show this error for now (#2205) Changing validator group voting gold (#2171) Add attestation info for reconnecting (#2195) Add reconnecting to a network to docs (#2190) Add instructions for transitioning from phase 1.0 to phase 1.1 (#2177) VM monitoring, bigger VMs, persistent disks for full nodes, prom to sd for proxies (#2176)
aaronmgdr
added a commit
that referenced
this pull request
Dec 12, 2019
* master: (41 commits) Add /test_attestations endpoint on the attestation service (#2189) Overhaul readme (#2201) Dont show this error for now (#2205) Changing validator group voting gold (#2171) Add attestation info for reconnecting (#2195) Add reconnecting to a network to docs (#2190) Add instructions for transitioning from phase 1.0 to phase 1.1 (#2177) VM monitoring, bigger VMs, persistent disks for full nodes, prom to sd for proxies (#2176) Three little improvements to website (#2161) Fix/contractkit test flakyness (#2150) [Wallet] Fix bug causing banner to stay visible once app is connected (#2154) Update documentation for Proxy IP addresses and ports (#2179) Add Baklava phase 1.1 accounts to genesis block (#2173) Use fluentd natively for structured logging (#2174) Swallowing error for more friendly cli UX (#2175) Allow the validator account to whitelist hotfixes (#2166) Clarify requirements for local vs remote machines (#2172) Calculate epoch rewards adjusted for validator group uptime (#2104) Remove ref to script, dont expose port on ext interface in docker cmd lines, add back security reminder about this. Remove ref to office hours (#2170) Slashing: Adding forceDeaffiliateIfValidator fn to Validators.sol (#2095) ... # Conflicts: # packages/web/src/about/Team.tsx # packages/web/src/about/VideoCover.tsx # packages/web/src/utils/utils.ts
aaronmgdr
added a commit
that referenced
this pull request
Dec 12, 2019
* master: (377 commits) Add /test_attestations endpoint on the attestation service (#2189) Overhaul readme (#2201) Dont show this error for now (#2205) Changing validator group voting gold (#2171) Add attestation info for reconnecting (#2195) Add reconnecting to a network to docs (#2190) Add instructions for transitioning from phase 1.0 to phase 1.1 (#2177) VM monitoring, bigger VMs, persistent disks for full nodes, prom to sd for proxies (#2176) Three little improvements to website (#2161) Fix/contractkit test flakyness (#2150) [Wallet] Fix bug causing banner to stay visible once app is connected (#2154) Update documentation for Proxy IP addresses and ports (#2179) Add Baklava phase 1.1 accounts to genesis block (#2173) Use fluentd natively for structured logging (#2174) Swallowing error for more friendly cli UX (#2175) Allow the validator account to whitelist hotfixes (#2166) Clarify requirements for local vs remote machines (#2172) Calculate epoch rewards adjusted for validator group uptime (#2104) Remove ref to script, dont expose port on ext interface in docker cmd lines, add back security reminder about this. Remove ref to office hours (#2170) Slashing: Adding forceDeaffiliateIfValidator fn to Validators.sol (#2095) ... # Conflicts: # packages/web/src/community/connect/ConnectPage.tsx # packages/web/src/community/connect/Fellow.tsx # packages/web/src/dev/CoverAction.tsx # packages/web/src/ecosystem/EcoFund.tsx # packages/web/src/shared/Button.3.tsx # packages/web/src/shared/ConnectionFooter.tsx # packages/web/src/shared/SocialChannels.tsx # packages/web/src/shared/menu-items.ts # packages/web/static/locales/en/community.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the amount of voted gold from all of group's gold to a configurable parameter of less gold for all the groups except the first and final group, which still vote with ~100k gold to maintain a presence in elections for monitoring.
Tested
CI tests
Other changes
Added config var
groupLockedGold