Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fluentd natively for structured logging #2174

Merged
merged 4 commits into from
Dec 11, 2019

Conversation

nambrot
Copy link
Contributor

@nambrot nambrot commented Dec 11, 2019

Description

We have used the gcplogs docker logging driver, however that one was basically impossible to configure. Instead, we are using the already installed google-fluentd agent with the fluentd log driver to parse JSON where possible. This should still print out non json lines as well. We could probably make an actual geth filter, but for now this should do

Tested

on my testnet namtest

Other changes

Describe any minor or "drive-by" changes here.

Related issues

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

@nambrot nambrot added the automerge Have PR merge automatically when checks pass label Dec 11, 2019
Copy link
Contributor

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@celo-ci-bot-user celo-ci-bot-user merged commit 2cbf04b into master Dec 11, 2019
@celo-ci-bot-user celo-ci-bot-user deleted the nambrot/structured-vm-logging branch December 11, 2019 03:54
aaronmgdr added a commit that referenced this pull request Dec 12, 2019
* master: (41 commits)
  Add /test_attestations endpoint on the attestation service (#2189)
  Overhaul readme (#2201)
  Dont show this error for now (#2205)
  Changing validator group voting gold (#2171)
  Add attestation info for reconnecting (#2195)
  Add reconnecting to a network to docs (#2190)
  Add instructions for transitioning from phase 1.0 to phase 1.1 (#2177)
  VM monitoring, bigger VMs, persistent disks for full nodes, prom to sd for proxies (#2176)
  Three little improvements to website (#2161)
  Fix/contractkit test flakyness (#2150)
  [Wallet] Fix bug causing banner to stay visible once app is connected (#2154)
  Update documentation for Proxy IP addresses and ports (#2179)
  Add Baklava phase 1.1 accounts to genesis block (#2173)
  Use fluentd natively for structured logging (#2174)
  Swallowing error for more friendly cli UX (#2175)
  Allow the validator account to whitelist hotfixes (#2166)
  Clarify requirements for local vs remote machines (#2172)
  Calculate epoch rewards adjusted for validator group uptime (#2104)
  Remove ref to script, dont expose port on ext interface in docker cmd lines, add back security reminder about this. Remove ref to office hours (#2170)
  Slashing: Adding forceDeaffiliateIfValidator fn to Validators.sol (#2095)
  ...

# Conflicts:
#	packages/web/src/about/Team.tsx
#	packages/web/src/about/VideoCover.tsx
#	packages/web/src/utils/utils.ts
aaronmgdr added a commit that referenced this pull request Dec 12, 2019
* master: (377 commits)
  Add /test_attestations endpoint on the attestation service (#2189)
  Overhaul readme (#2201)
  Dont show this error for now (#2205)
  Changing validator group voting gold (#2171)
  Add attestation info for reconnecting (#2195)
  Add reconnecting to a network to docs (#2190)
  Add instructions for transitioning from phase 1.0 to phase 1.1 (#2177)
  VM monitoring, bigger VMs, persistent disks for full nodes, prom to sd for proxies (#2176)
  Three little improvements to website (#2161)
  Fix/contractkit test flakyness (#2150)
  [Wallet] Fix bug causing banner to stay visible once app is connected (#2154)
  Update documentation for Proxy IP addresses and ports (#2179)
  Add Baklava phase 1.1 accounts to genesis block (#2173)
  Use fluentd natively for structured logging (#2174)
  Swallowing error for more friendly cli UX (#2175)
  Allow the validator account to whitelist hotfixes (#2166)
  Clarify requirements for local vs remote machines (#2172)
  Calculate epoch rewards adjusted for validator group uptime (#2104)
  Remove ref to script, dont expose port on ext interface in docker cmd lines, add back security reminder about this. Remove ref to office hours (#2170)
  Slashing: Adding forceDeaffiliateIfValidator fn to Validators.sol (#2095)
  ...

# Conflicts:
#	packages/web/src/community/connect/ConnectPage.tsx
#	packages/web/src/community/connect/Fellow.tsx
#	packages/web/src/dev/CoverAction.tsx
#	packages/web/src/ecosystem/EcoFund.tsx
#	packages/web/src/shared/Button.3.tsx
#	packages/web/src/shared/ConnectionFooter.tsx
#	packages/web/src/shared/SocialChannels.tsx
#	packages/web/src/shared/menu-items.ts
#	packages/web/static/locales/en/community.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structured logging for VM testnets
4 participants