-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fluentd natively for structured logging #2174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkporter
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
aaronmgdr
added a commit
that referenced
this pull request
Dec 12, 2019
* master: (41 commits) Add /test_attestations endpoint on the attestation service (#2189) Overhaul readme (#2201) Dont show this error for now (#2205) Changing validator group voting gold (#2171) Add attestation info for reconnecting (#2195) Add reconnecting to a network to docs (#2190) Add instructions for transitioning from phase 1.0 to phase 1.1 (#2177) VM monitoring, bigger VMs, persistent disks for full nodes, prom to sd for proxies (#2176) Three little improvements to website (#2161) Fix/contractkit test flakyness (#2150) [Wallet] Fix bug causing banner to stay visible once app is connected (#2154) Update documentation for Proxy IP addresses and ports (#2179) Add Baklava phase 1.1 accounts to genesis block (#2173) Use fluentd natively for structured logging (#2174) Swallowing error for more friendly cli UX (#2175) Allow the validator account to whitelist hotfixes (#2166) Clarify requirements for local vs remote machines (#2172) Calculate epoch rewards adjusted for validator group uptime (#2104) Remove ref to script, dont expose port on ext interface in docker cmd lines, add back security reminder about this. Remove ref to office hours (#2170) Slashing: Adding forceDeaffiliateIfValidator fn to Validators.sol (#2095) ... # Conflicts: # packages/web/src/about/Team.tsx # packages/web/src/about/VideoCover.tsx # packages/web/src/utils/utils.ts
aaronmgdr
added a commit
that referenced
this pull request
Dec 12, 2019
* master: (377 commits) Add /test_attestations endpoint on the attestation service (#2189) Overhaul readme (#2201) Dont show this error for now (#2205) Changing validator group voting gold (#2171) Add attestation info for reconnecting (#2195) Add reconnecting to a network to docs (#2190) Add instructions for transitioning from phase 1.0 to phase 1.1 (#2177) VM monitoring, bigger VMs, persistent disks for full nodes, prom to sd for proxies (#2176) Three little improvements to website (#2161) Fix/contractkit test flakyness (#2150) [Wallet] Fix bug causing banner to stay visible once app is connected (#2154) Update documentation for Proxy IP addresses and ports (#2179) Add Baklava phase 1.1 accounts to genesis block (#2173) Use fluentd natively for structured logging (#2174) Swallowing error for more friendly cli UX (#2175) Allow the validator account to whitelist hotfixes (#2166) Clarify requirements for local vs remote machines (#2172) Calculate epoch rewards adjusted for validator group uptime (#2104) Remove ref to script, dont expose port on ext interface in docker cmd lines, add back security reminder about this. Remove ref to office hours (#2170) Slashing: Adding forceDeaffiliateIfValidator fn to Validators.sol (#2095) ... # Conflicts: # packages/web/src/community/connect/ConnectPage.tsx # packages/web/src/community/connect/Fellow.tsx # packages/web/src/dev/CoverAction.tsx # packages/web/src/ecosystem/EcoFund.tsx # packages/web/src/shared/Button.3.tsx # packages/web/src/shared/ConnectionFooter.tsx # packages/web/src/shared/SocialChannels.tsx # packages/web/src/shared/menu-items.ts # packages/web/static/locales/en/community.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have used the
gcplogs
docker logging driver, however that one was basically impossible to configure. Instead, we are using the already installedgoogle-fluentd
agent with thefluentd
log driver to parse JSON where possible. This should still print out non json lines as well. We could probably make an actual geth filter, but for now this should doTested
on my testnet
namtest
Other changes
Describe any minor or "drive-by" changes here.
Related issues
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.