Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Dependencies and get react hooks working #2203

Merged
merged 9 commits into from
Dec 12, 2019

Conversation

aaronmgdr
Copy link
Member

Description

  • upgrade nuka carousel => this fixes deprecation warning
  • Requires exact react version (before it was using 16.10.2 in lock file) this keeps version same as other packages and ensures just one version is used on website which means we can finally use hooks
  • upgrade next-i18next => better typsescript support

Tested

wrote a simple useState hook!

Other changes

Related issues

Backwards compatibility

next-i18next has changes to module names

* master:
  Add /test_attestations endpoint on the attestation service (#2189)
  Overhaul readme (#2201)
  Dont show this error for now (#2205)
  Changing validator group voting gold (#2171)
  Add attestation info for reconnecting (#2195)
  Add reconnecting to a network to docs (#2190)
  Add instructions for transitioning from phase 1.0 to phase 1.1 (#2177)
  VM monitoring, bigger VMs, persistent disks for full nodes, prom to sd for proxies (#2176)
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #2203 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2203    +/-   ##
========================================
  Coverage   74.81%   74.81%            
========================================
  Files         276      276            
  Lines        7766     7766            
  Branches      976      692   -284     
========================================
  Hits         5810     5810            
  Misses       1839     1839            
  Partials      117      117
Flag Coverage Δ
#mobile 74.81% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/mobile/src/import/ImportContacts.tsx 74.5% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d4cad...9fa5edd. Read the comment docs.

@aaronmgdr aaronmgdr changed the title Upgrade Depends and get react hooks working Upgrade Dependencies and get react hooks working Dec 12, 2019
@aaronmgdr aaronmgdr added the automerge Have PR merge automatically when checks pass label Dec 12, 2019
@celo-ci-bot-user celo-ci-bot-user merged commit 1426589 into master Dec 12, 2019
@celo-ci-bot-user celo-ci-bot-user deleted the aaronmgdr/upgrade-dependents branch December 12, 2019 21:40
aaronmgdr added a commit that referenced this pull request Dec 16, 2019
* master: (40 commits)
  Add utils as a dep (#2252)
  [Wallet] Create run_app.sh script to facilitate app development (#2186)
  [Wallet] Fix persisted data loss on iOS (#2249)
  adds Testing TSX /react on the web (#2229)
  Update running-a-validator.md (#2259)
  Add ts-ignore (#2254)
  Revert "Revert "Upgrade TS version (#2196)" (#2251)" (#2255)
  Force same bignumber version (#2256)
  Fix missing Text on website (#2237)
  Revert "Upgrade TS version (#2196)" (#2251)
  [Wallet] Refer to Celo Lite as "Data Saver" mode (#2232)
  Fix using requester instead of requestee at Outgoing notifications (#2240)
  Use correct phone placeholder depending on the country on joining Celo view (#2061)
  Update Attestation Bot Docker Image (#2231)
  Baklava phase 1.1 .env file (#2226)
  [Docs] Fix typo (#2225)
  Upgrade Dependencies and get react hooks working (#2203)
  Update attestation service docker images (#2202)
  Updates TME docker images (#2200)
  Remove walletkit from celotool transactions commands (#2206)
  ...

# Conflicts:
#	packages/web/package.json
aaronmgdr added a commit that referenced this pull request Dec 16, 2019
* master:
  Add utils as a dep (#2252)
  [Wallet] Create run_app.sh script to facilitate app development (#2186)
  [Wallet] Fix persisted data loss on iOS (#2249)
  adds Testing TSX /react on the web (#2229)
  Update running-a-validator.md (#2259)
  Add ts-ignore (#2254)
  Revert "Revert "Upgrade TS version (#2196)" (#2251)" (#2255)
  Force same bignumber version (#2256)
  Fix missing Text on website (#2237)
  Revert "Upgrade TS version (#2196)" (#2251)
  [Wallet] Refer to Celo Lite as "Data Saver" mode (#2232)
  Fix using requester instead of requestee at Outgoing notifications (#2240)
  Use correct phone placeholder depending on the country on joining Celo view (#2061)
  Update Attestation Bot Docker Image (#2231)
  Baklava phase 1.1 .env file (#2226)
  [Docs] Fix typo (#2225)
  Upgrade Dependencies and get react hooks working (#2203)
  Update attestation service docker images (#2202)
  Updates TME docker images (#2200)
  Remove walletkit from celotool transactions commands (#2206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable react hooks
3 participants