Adding slashing multiplier to validators.sol and reward calculation #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaj
reviewed
Dec 13, 2019
lucasege
force-pushed
the
lucasege/slashing-multiplier
branch
2 times, most recently
from
260b8c4
to
24e8ab5
Compare
asaj
approved these changes
Dec 17, 2019
| * @notice Halves the group's slashing multiplier. | ||
| * @param account The group being slashed. | ||
| */ | ||
| function halveSlashingMultiplier(address account) |
There was a problem hiding this comment.
Been thinking about this more, and wondering if it makes sense for different slashers to set their own multiplier between 0 and 1, let's discuss more offline
lucasege
force-pushed
the
lucasege/slashing-multiplier
branch
from
24e8ab5
to
fb01b11
Compare
Codecov Report
@@ Coverage Diff @@
## master #2239 +/- ##
========================================
Coverage 74.89% 74.89%
========================================
Files 274 274
Lines 7803 7803
Branches 701 985 +284
========================================
Hits 5844 5844
Misses 1846 1846
Partials 113 113
Continue to review full report at Codecov.
|
added 10 commits
December 17, 2019 09:49
lucasege
force-pushed
the
lucasege/slashing-multiplier
branch
from
d58d406
to
e424be8
Compare
aaronmgdr
added a commit
that referenced
this pull request
Dec 17, 2019
* master: Adding slashing multiplier to validators.sol and reward calculation (#2239) Update genesis value, show name in election:list, fix assertRevert (#2216) Audit fixes for Reserve (#1816) Adapting the script to the last documentation changes (#2241) Bump excon from 0.65.0 to 0.71.0 in /packages/mobile (#2274) Fix wrong type for comment key (#2250) Fix/block gas limit exceeded #2 (#2263) Stop running broken end-to-end mobile test (#2096) [Wallet] Fix non integer wei issue in exchange (#2277) Fix validatorgroup:list bug by not fetching unneeded info (#2257) [Wallet] New exchange trade screen and fix ts build in celotool (#2167) Update Role on About Page (#2271) # Conflicts: # packages/web/src/about/team/team-list.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
setSlashingMultiplierResetPeriod,resetSlashingMultiplier,getValidatorGroupSlashingMultiplierandhalveSlashingMultipliertoValidators.sol, as well as adding record keeping to faciliate this:GroupSlashInfostruct which is stored within theValidatorGroupstruct and maintains the group'sslashingModifier(Min the docs) and thelastSlashedTimestampwhich tracks the last time a group was slashed to control when the multiplier can be reset yet.Tested
Added unit tests for each fn in Validators contract.
Other changes
Fixed a bug in
Validators.solwhere we were callingsignerToAccountwhen we should have been callingvalidatorSignerToAccount. Updated this in most functions that calledsignerToAccountwith a few exceptions:_updateValidatorScoreFromSigner,_distributeEpochPaymentsFromSigner,getValidatorBlsPublicKeyFromSigner, andgetMembershipInLastEpochFromSigner.Changed
Validators.solinitializefn signature, IValidators contract, and the MockValidators contract. I also changed thegasLimitwithin truffle config and the ganache config inrunTestssince it was running out of gas when I changed Validator.Related issues
Backwards compatibility
No, changes to initialize fn in Validator