Fix/block gas limit exceeded #2 #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2263 +/- ##
========================================
Coverage 74.89% 74.89%
========================================
Files 274 274
Lines 7802 7802
Branches 701 985 +284
========================================
Hits 5843 5843
Misses 1846 1846
Partials 113 113
Continue to review full report at Codecov.
|
H34D
added
automerge
asaj
approved these changes
Dec 17, 2019
aaronmgdr
added a commit
that referenced
this pull request
Dec 17, 2019
* master: Adding slashing multiplier to validators.sol and reward calculation (#2239) Update genesis value, show name in election:list, fix assertRevert (#2216) Audit fixes for Reserve (#1816) Adapting the script to the last documentation changes (#2241) Bump excon from 0.65.0 to 0.71.0 in /packages/mobile (#2274) Fix wrong type for comment key (#2250) Fix/block gas limit exceeded #2 (#2263) Stop running broken end-to-end mobile test (#2096) [Wallet] Fix non integer wei issue in exchange (#2277) Fix validatorgroup:list bug by not fetching unneeded info (#2257) [Wallet] New exchange trade screen and fix ts build in celotool (#2167) Update Role on About Page (#2271) # Conflicts: # packages/web/src/about/team/team-list.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From time to time i get
block gas limit exceededon the e2e tests right in the migrations. I am pretty sure this is the cause.It looks a little like this when it happens:
Tested
yarn testusing e2e tests
Issues
Related to: #1639