Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/block gas limit exceeded #2 #2263

Merged
merged 5 commits into from
Dec 17, 2019
Merged

Fix/block gas limit exceeded #2 #2263

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1698550
fix massive gas overspending
H34D Dec 12, 2019
471ac21
Merge branch 'master' into fix/gas_overspend
H34D Dec 16, 2019
b7f3a09
try with more gas?
H34D Dec 16, 2019
95a8110
Merge branch 'master' into fix/gas_overspend
H34D Dec 16, 2019
a0f2c2d
Merge branch 'master' into fix/gas_overspend
H34D Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/protocol/lib/web3-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export async function sendTransactionWithPrivateKey<T>(
// Encode data and estimate gas or use default values for a transfer.
let encodedTxData: string|undefined
let estimatedGas = 21000 // Gas cost of a basic transfer.

if (tx !== null) {
encodedTxData = tx.encodeABI()
estimatedGas = await tx.estimateGas({
Expand All @@ -35,7 +36,9 @@ export async function sendTransactionWithPrivateKey<T>(
...txArgs,
data: encodedTxData,
from: address,
gas: estimatedGas * 10,
// make sure to use enough gas but dont overspend
// or we will run into "block gas limit exceeded" errors
gas: estimatedGas * 2,
},
privateKey
)
Expand Down