Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate time based parameters #2377

Merged
merged 6 commits into from
Jan 8, 2020

Conversation

lucasege
Copy link
Contributor

@lucasege lucasege commented Jan 7, 2020

Description

Accelerating some parameters to allow for testing conditions more readily.

Tested

Ran CI

Related issues

Backwards compatibility

Yes

@lucasege
Copy link
Contributor Author

lucasege commented Jan 7, 2020

Unsure about:

  • tobinTaxStalenessThreshold - should I also reduce?
  • Should I actually reduce slashingPenaltyResetPeriod?
  • Any others I missed?

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #2377 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2377    +/-   ##
========================================
  Coverage   74.52%   74.52%            
========================================
  Files         278      278            
  Lines        7777     7777            
  Branches      709      992   +283     
========================================
  Hits         5796     5796            
  Misses       1869     1869            
  Partials      112      112
Flag Coverage Δ
#mobile 74.52% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecba13c...cac88fd. Read the comment docs.

@asaj asaj assigned lucasege and unassigned asaj Jan 8, 2020
@lucasege lucasege added the automerge Have PR merge automatically when checks pass label Jan 8, 2020
@celo-ci-bot-user celo-ci-bot-user merged commit 82cc938 into master Jan 8, 2020
@celo-ci-bot-user celo-ci-bot-user deleted the lucasege/accelerate-migrations-config branch January 8, 2020 22:47
aaronmgdr added a commit that referenced this pull request Jan 9, 2020
* master: (139 commits)
  Accelerate time based parameters (#2377)
  Fix circle not being started (#2380)
  Blockscout logs patch for json format (#2268)
  [Wallet] Fix slow activity feed tx confirmations (#2290)
  Aaronmgdr/about followup (#2376)
  Change "not syncing" to "not synced" (#2372)
  [Docs] Update Contributing guide with links to good first issues  (#2375)
  Optimize Bundles (#2352)
  Update blockscout for alfajores and pilot envs (#1954)
  Make the same hotfix proposal executable with unique salts (#2357)
  Fix Contribution Guildelines in the docs (#2370)
  Add Snapshot for each page on website (#2313)
  Turn on Emit (#2369)
  Update to latest blockchain with select issuers fix (#2362)
  Add docs on how to generate sms retriever hash (#2356)
  Aaronmgdr/about below (#1194)
  Switch to using native pbkdf to fix hanging on older devices (#2354)
  Adding a command to the docker script allowing to stop validating (#2295)
  Update prettier to 1.19.1 to support TypeScript 3.7 (optional chaining, nullish coalescing, etc) (#2358)
  Fixes needed to make slashing work (#2346)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All time based parameters should be accelerated 24x in migration config
3 participants