Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Bundles #2352

Merged
merged 20 commits into from
Jan 7, 2020
Merged

Optimize Bundles #2352

merged 20 commits into from
Jan 7, 2020

Conversation

aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Jan 2, 2020

Description

defer loading of some libraries and components, rewrite to remove code, and generally do what can be done to decrease bytes sent to browser

  • Defer loading Sentry
  • defer loading the segment/isEU library
  • replace React.Animated with a few lines of CSS
  • Lazy Load the Carousel on the homepage
  • combine SVGs of the celo logo light and celo logo dark into one svg with a light and dark prop

Tested

using yarn build with expo showing sizes of each page bundle and via the webkit-bundle-visualizer
Screen Shot 2020-01-02 at 4 49 03 PM

Related issues

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

* master: (26 commits)
  Added new lint rule (#2349)
  [Slashing] Slash locked gold (#2317)
  [Slashing] Allow voting gold to be slashable (#2302)
  1666 precompiles assembly rewrite (#2324)
  Small fixes to deploy web (#2343)
  Governance, downtime and double signing slasher contracts (#2267)
  Added daily limit for reserve spending (#2303)
  Fixing multisig tests (#2342)
  [Wallet] Implement new send & import flow (#2332)
  Limechain/16xx (#1982)
  Add infinite pagination to Leaderboard (#2339)
  cli: Add rewards:show (#2160)
  Correct broken link formatting
  Celotool command for deploying hotfixes (#2142)
  Governance ContractKit + CLI changes (#2139)
  Complete codependent slashing precompile PRs (#2333)
  Add new and modified precompiles to UsingPrecompiles.sol (#2318)
  Adding error messages to contracts (#1182)
  Upgrade i18next and react-i18next to latest across monorepo (#2311)
  [Wallet] Fix exchange input on iOS and feed item display (#2319)
  ...

# Conflicts:
#	yarn.lock
yarn.lock Outdated Show resolved Hide resolved
* master:
  Adding a command to the docker script allowing to stop validating (#2295)
  Update prettier to 1.19.1 to support TypeScript 3.7 (optional chaining, nullish coalescing, etc) (#2358)
  Fixes needed to make slashing work (#2346)
  Remove Rewards page from web (#2353)
  Remove rep sentence from brand kit page (#2350)

# Conflicts:
#	packages/web/src/header/Header.3.tsx
#	yarn.lock
* master:
  Add docs on how to generate sms retriever hash (#2356)
  Aaronmgdr/about below (#1194)
  Switch to using native pbkdf to fix hanging on older devices (#2354)

# Conflicts:
#	packages/web/src/fonts/Fonts.tsx
* master:
  Update to latest blockchain with select issuers fix (#2362)
@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #2352 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2352   +/-   ##
=======================================
  Coverage   74.55%   74.55%           
=======================================
  Files         278      278           
  Lines        7777     7777           
  Branches      707      707           
=======================================
  Hits         5798     5798           
  Misses       1868     1868           
  Partials      111      111
Flag Coverage Δ
#mobile 74.55% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e2dc9...eda8e88. Read the comment docs.

* master:
  Make the same hotfix proposal executable with unique salts (#2357)
  Fix Contribution Guildelines in the docs (#2370)
  Add Snapshot for each page on website (#2313)
  Turn on Emit (#2369)
packages/web/src/analytics/analytics.ts Outdated Show resolved Hide resolved
* master:
  Update blockscout for alfajores and pilot envs (#1954)
@aaronmgdr aaronmgdr added the automerge Have PR merge automatically when checks pass label Jan 7, 2020
@celo-ci-bot-user celo-ci-bot-user merged commit 38234e7 into master Jan 7, 2020
@celo-ci-bot-user celo-ci-bot-user deleted the aaronmgdr/static branch January 7, 2020 22:23
aaronmgdr added a commit that referenced this pull request Jan 9, 2020
* master: (139 commits)
  Accelerate time based parameters (#2377)
  Fix circle not being started (#2380)
  Blockscout logs patch for json format (#2268)
  [Wallet] Fix slow activity feed tx confirmations (#2290)
  Aaronmgdr/about followup (#2376)
  Change "not syncing" to "not synced" (#2372)
  [Docs] Update Contributing guide with links to good first issues  (#2375)
  Optimize Bundles (#2352)
  Update blockscout for alfajores and pilot envs (#1954)
  Make the same hotfix proposal executable with unique salts (#2357)
  Fix Contribution Guildelines in the docs (#2370)
  Add Snapshot for each page on website (#2313)
  Turn on Emit (#2369)
  Update to latest blockchain with select issuers fix (#2362)
  Add docs on how to generate sms retriever hash (#2356)
  Aaronmgdr/about below (#1194)
  Switch to using native pbkdf to fix hanging on older devices (#2354)
  Adding a command to the docker script allowing to stop validating (#2295)
  Update prettier to 1.19.1 to support TypeScript 3.7 (optional chaining, nullish coalescing, etc) (#2358)
  Fixes needed to make slashing work (#2346)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce bundle sizes on website
3 participants