Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: Bump polkadot to v0.9.13 #527

Closed
wants to merge 18 commits into from
Closed

wip: Bump polkadot to v0.9.13 #527

wants to merge 18 commits into from

Conversation

NunoAlexandre
Copy link
Contributor

@NunoAlexandre NunoAlexandre commented Nov 26, 2021 •
edited
Loading

  • Bump version of polkadot
  • Bump substrate
  • Bump cumulus
  • Fix compilation issues
  • Run tests
  • Update docker image
  • Ensure that the relay-chain produces blocks
  • Ensue that the para-chain produces blocks

@NunoAlexandre NunoAlexandre self-assigned this Nov 26, 2021
@NunoAlexandre NunoAlexandre marked this pull request as draft November 26, 2021 13:05
@NunoAlexandre
Bump bridgechain and unique-assets
724a37f
@NunoAlexandre
Bump polkadot --branch release-v0.9.13
a62577a 
I had bump it to --tag v0.9.13-rc1, which is not what cumulus points to,
causing cargo to create a copy of all the substrate crates and leading
to lots of error types.
@NunoAlexandre
Copy link
Contributor Author

NunoAlexandre commented Nov 26, 2021 •
edited
Loading

State dump

As of #a62577a, running cargo build fails with the following error:

   Compiling beefy-gadget-rpc v4.0.0-dev (https://github.com/paritytech/substrate?branch=polkadot-v0.9.13#de6033a2)
error[E0308]: mismatched types
  --> /Users/n/.cargo/git/checkouts/polkadot-4038f27d5e4ea2e8/bff00af/node/network/protocol/src/authority_discovery.rs:51:3
   |
51 |         AuthorityDiscoveryService::get_addresses_by_authority_id(self, authority).await
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `Vec`, found struct `HashSet`
   |
   = note: expected enum `Option<Vec<Multiaddr>>`
              found enum `Option<HashSet<Multiaddr>>`
note: return type inferred to be `Option<Vec<Multiaddr>>` here

We better wait until polkadot and substrate have finalised their respective 0.9.13 versions as going on creating forks requires forks for substrate, polkadot, and cumulus at no benefit for us right now.

@NunoAlexandre
Copy link
Contributor Author

@mustermeiszer what is the best base branch for this bump? 🤔

@mustermeiszer
Copy link
Collaborator

Parachain. We rebase rt3-rc2 and rt4 then. Or rebase this one, when we device to not bring in polkadot-v0.9.13 in our side. Its a bit of hustle to test, if there where any migrations or other changes on the substrate side. But we will see.

@NunoAlexandre
Copy link
Contributor Author

Parachain. We rebase rt3-rc2 and rt4 then. Or rebase this one, when we device to not bring in polkadot-v0.9.13 in our side. Its a bit of hustle to test, if there where any migrations or other changes on the substrate side. But we will see.

Cool, thanks man!

@NunoAlexandre
Bump polkadot to release tag 0.9.13
305df06
@NunoAlexandre
run Cargo update
f1a27f5
@NunoAlexandre
drop changes_trie_config: Default::default(),
7bd9532 
This field no longer exists in frame_system::pallet::GenesisConfig.
@NunoAlexandre
try: Point to my fork of cumulus with latest polkadot
85c97a5
@NunoAlexandre
cargo update
77de9cb 
This resolves the typing issue caused by having two versions of the same
crate lingering around.
@NunoAlexandre
fix type inference issue
36d7584
@NunoAlexandre
Pass new group name param to spawn
1a1f840
@NunoAlexandre
Add parachain_id opt to the Cli
4b0896c 
This field is no longer made available through
cumulus_client_cli::RunCmd so we add it explicitly to our own Cli
struct.
@NunoAlexandre
Bump polkadot docker images
b27cf97
@NunoAlexandre
Fix compilation error in tests
9780597
NunoAlexandre
NunoAlexandre commented Dec 8, 2021
View reviewed changes
docker-compose-local-relay.yml
Comment on lines +16 to +18
--chain=/chainspec.json --wasm-execution=compiled --execution=wasm
--no-beefy --base-path=/data --port 30333 --rpc-port 9933 --ws-port 9944
--rpc-external --rpc-cors all --ws-external --rpc-methods=Unsafe --alice
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes must have been caused by my editor, not intentional 🙃

@NunoAlexandre
Merge remote-tracking branch 'origin/parachain' into bump/polkadot
7d4d4f9
@NunoAlexandre
Update res/rococo-local.json
a5fd141 
Block production worked after onboarding but it halted after producing
block #3.
@NunoAlexandre NunoAlexandre removed their assignment Jan 10, 2022
@NunoAlexandre
Copy link
Contributor Author

Closed in favour of #611

@NunoAlexandre NunoAlexandre deleted the bump/polkadot branch February 2, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NunoAlexandre @mustermeiszer