Altair Runtime Upgrade 5 + Polkadot upgrade to v0.9.16 #611

mikiquantum · 2022-01-29T01:33:03Z

This PR aims to:

Upgrade dependencies to polkadot/substrate/cumulus/orml v0.9.16
Include Uniques pallet in Altair runtime
*-dev runtime suffix becomes ChainType::Live and *-local ChainType::Local
Starting to use node versioning

…to parachain

mikiquantum · 2022-01-29T01:34:34Z

pallets/loans/Cargo.toml

+frame-benchmarking = { git = "https://github.com/paritytech/substrate",  default-features = false , optional = true , branch = "polkadot-v0.9.16" }
+pallet-balances = { git = "https://github.com/paritytech/substrate",  default-features = false , optional = true, branch = "polkadot-v0.9.16" }
+pallet-uniques = { git = "https://github.com/paritytech/substrate",  default-features = false , optional = true, branch = "polkadot-v0.9.16" }
+orml-tokens = { git = "https://github.com/open-web3-stack/open-runtime-module-library", default-features = false, optional = true, branch = "new_reanchor" }


Haven't released yet v0.9.16 on ORML but PR on this branch is open and active, should be published soon.

mikiquantum · 2022-01-29T01:36:04Z

runtime/development/src/lib.rs

 >;

+// Migration for scheduler pallet to move from a plain Call to a CallOrHash.
+pub struct SchedulerMigrationV3;


Not sure if it is needed for this stateless runtime, but should not harm.

I think unless/until we have some sort of persistent development chain running somewhere, this isn't needed.

If it makes sense to add/remove the migrations here at the same time as elsewhere let's go ahead and do it, though, just to keep things consistent.

NunoAlexandre

Looks good overall. I think we need to update some of our commands given that the --parachain-id option is not expected at a different location. I can look a this later this weekend or on Monday morning

pallets/crowdloan-reward/src/lib.rs

runtime/altair/src/lib.rs

mikiquantum · 2022-01-30T01:22:43Z

pallets/loans/Cargo.toml

+frame-benchmarking = { git = "https://github.com/paritytech/substrate",  default-features = false , optional = true , branch = "polkadot-v0.9.16" }
+pallet-balances = { git = "https://github.com/paritytech/substrate",  default-features = false , optional = true, branch = "polkadot-v0.9.16" }
+pallet-uniques = { git = "https://github.com/paritytech/substrate",  default-features = false , optional = true, branch = "polkadot-v0.9.16" }
+orml-tokens = { git = "https://github.com/open-web3-stack/open-runtime-module-library", default-features = false, optional = true, branch = "master" }


tmp - until v0.9.16 is released

mustermeiszer

LGTM! Thanks for handling this so fast @mikiquantum!!

Just wanna clarify why we change the runtime version bumb

from: 100(x) -> 100(x+1)
to: 1(x)00 -> 1(x+1)00

mustermeiszer · 2022-01-30T18:32:57Z

libs/common-traits/src/lib.rs

@@ -47,7 +47,6 @@ use sp_std::vec::Vec;
 pub trait Reward {
 	/// The account from the parachain, that the claimer provided in her/his transaction.
 	type ParachainAccountId: Debug
-		+ Default


mustermeiszer · 2022-01-30T18:33:15Z

pallets/anchors/src/lib.rs

@@ -89,6 +90,7 @@ pub mod pallet {
 	// method.
 	#[pallet::pallet]
 	#[pallet::generate_store(pub (super) trait Store)]
+	#[pallet::without_storage_info]


What is this for?

Looks related to paritytech/substrate#10662.
Sounds like this attribute is a bit of a hack and we should work on being able to remove it? But that can be a future upgrade, the less we change when we're in a hurry the better.

Would be nice to ticket this, though.

mustermeiszer · 2022-01-30T18:35:44Z

pallets/collator-allowlist/src/mock.rs

@@ -63,6 +63,7 @@ impl frame_system::Config for Test {
 	type SystemWeightInfo = ();
 	type SS58Prefix = ();
 	type OnSetCode = ();
+	type MaxConsumers = frame_support::traits::ConstU32<16>;


Why ist this needed? What did Parity do? ^^

paritytech/substrate#10382

mustermeiszer · 2022-01-30T18:37:41Z

pallets/registry/src/mock.rs

+pub struct AuthorGiven;
+
+impl FindAuthor<u64> for AuthorGiven {
+	fn find_author<'a, I>(_digests: I) -> Option<u64>
+	where
+		I: 'a + IntoIterator<Item = (ConsensusEngineId, &'a [u8])>,
+	{
+		Some(100)
+	}
+}
+


Does anybody know what was the issue with that? Only saw in the commits of the latest version, that they changed the import logic of the node.

Storage of the block author author() is now an OptionQuery instead of a ValueQuery over the AccountId, which the trait now it doesn't support a Default value. Is either set or not. Hence this cascading list of changes.

mustermeiszer · 2022-01-30T18:38:21Z

runtime/altair/src/lib.rs

@@ -72,10 +70,14 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
 	spec_name: create_runtime_str!("altair"),
 	impl_name: create_runtime_str!("altair"),
 	authoring_version: 1,
-	spec_version: 1008,
+	spec_version: 1900,


Why the logical change here? What does it represent or is it a typo?

This matches how parity does their versioning - polkadot X.Y turns into runtime XY00. I'm not sure we need to do this, and I'm personally happy to just keep incrementing a release number without trying to tie it to any more formal versioning structure.

Since we are tied to updating the node as well and that follows a semver X.Y.Z. One reason I thought about using the same as parity is bc if we dont, then our x.y.z for 1008, would be 1.0.8, which puts us in version 1 already, which prob we are not ready for yet. Alternatively we can use 0.10.08 as the equivalent of 1008, I can change that too

Like the later more, but I am happy with both.

mustermeiszer · 2022-01-30T18:40:09Z

runtime/centrifuge/src/lib.rs

@@ -65,10 +65,14 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
 	spec_name: create_runtime_str!("centrifuge"),
 	impl_name: create_runtime_str!("centrifuge"),
 	authoring_version: 1,
-	spec_version: 1000,
+	spec_version: 1100,


Also new versions we use here?

mustermeiszer · 2022-01-30T18:42:22Z

src/chain_spec.rs

+	CentrifugeChainSpec::from_genesis(
+		"Centrifuge Dev",
+		"centrifuge_dev",
+		ChainType::Live,


Why live here?

My thought was that when developing locally you should use $runtime-local and when deploying as dev environment we can use the $runtime-dev and with a defined set of authorities. The reason being that ChainType::Local might not behave as expected in deployed environments.

branan · 2022-01-31T07:02:17Z

runtime/altair/src/lib.rs

 	type WeightInfo = pallet_utility::weights::SubstrateWeight<Self>;
 }

 parameter_types! {
 	pub MaximumSchedulerWeight: Weight = Perbill::from_percent(80) * MaximumBlockWeight::get();
 	pub const MaxScheduledPerBlock: u32 = 50;
+	// Retry a scheduled item every 10 blocks (1 minute) until the preimage exists.
+	pub const NoPreimagePostponement: Option<u32> = Some(10);


Comment is wrong - 10 blocks is 2 minutes for us

branan · 2022-01-31T07:03:40Z

runtime/altair/src/lib.rs

@@ -870,7 +865,8 @@ construct_runtime!(
 		Identity: pallet_identity::{Pallet, Call, Storage, Event<T>} = 67,
 		Vesting: pallet_vesting::{Pallet, Call, Storage, Event<T>, Config<T>} = 68,
 		Treasury: pallet_treasury::{Pallet, Call, Storage, Config, Event<T>} = 69,
-		// Uniques: pallet_uniques::{Pallet, Call, Storage, Event<T>} = 70,
+		Preimage: pallet_preimage::{Pallet, Call, Storage, Event<T>} = 70,
+		Uniques: pallet_uniques::{Pallet, Call, Storage, Event<T>} = 72,


No pallet 71?

It is defined a bit above, and seems that for some reasons there is an order dependency.

@mustermeiszer I just compiled successfully changing the order moving down pallet 71 to its ordered place, do you why you added it up there before?

When you start the chain the storage will not be present and we will not be to inject candidates from the collator-selection pallet. As mentioned in the comment.

Okay, then leaving it up there

branan · 2022-01-31T07:13:58Z

Nothing jumps out to me that @mustermeiszer didn't already comment on

NunoAlexandre · 2022-01-31T09:08:47Z

I think we need to update some of our commands given that the --parachain-id option is not expected at a different location. I can look a this later this weekend or on Monday morning

The parachain options seem fine! Just facing this error regarding the --no-beefy

mikiquantum added 8 commits January 10, 2022 10:56

add devops section to prep env script

4ce9b54

Merge branch 'parachain' of github.com:centrifuge/centrifuge-chain in…

e7d4d9b

…to parachain

Merge branch 'parachain' of github.com:centrifuge/centrifuge-chain in…

5195dc9

…to parachain

Merge branch 'parachain' of github.com:centrifuge/centrifuge-chain in…

0f154b7

…to parachain

Merge branch 'parachain' of github.com:centrifuge/centrifuge-chain in…

1c1412a

…to parachain

wip upgrade to v0.9.15

9430632

wip upgrade v0.9.16 - runtimes compile

cdcd13a

add scheduler migration

02d4ed9

mikiquantum commented Jan 29, 2022

View reviewed changes

mikiquantum added 3 commits January 28, 2022 19:04

fix chainspec + latest docker polkadot

c06c36b

node compiles + spec changes + node versioning

2544c7f

global node version

ec65c11

mikiquantum changed the title ~~Runtime Upgrade 5 + Polkadot upgrade to v0.9.16~~ Altair Runtime Upgrade 5 + Polkadot upgrade to v0.9.16 Jan 29, 2022

mikiquantum added 2 commits January 28, 2022 23:52

use orml master to check build

76319ae

change versioning

1ccd8ff

NunoAlexandre reviewed Jan 29, 2022

View reviewed changes

pallets/crowdloan-reward/src/lib.rs Outdated Show resolved Hide resolved

runtime/altair/src/lib.rs Outdated Show resolved Hide resolved

fix tests

1d19dc3

mikiquantum commented Jan 30, 2022

View reviewed changes

mikiquantum marked this pull request as ready for review January 30, 2022 01:22

mikiquantum requested review from branan and NunoAlexandre January 30, 2022 01:23

mustermeiszer approved these changes Jan 30, 2022

View reviewed changes

branan reviewed Jan 31, 2022

View reviewed changes

mikiquantum added 3 commits January 31, 2022 13:30

commens

a05dee1

remove no-beefy, disabled by default

dcce1ab

change runtime order

bff31da

mikiquantum added 2 commits February 1, 2022 16:12

use altair-local runtime in init script

8d57731

rename antares/charcoal dev to local

1916114

NunoAlexandre mentioned this pull request Feb 2, 2022

wip: Bump polkadot to v0.9.13 #527

Closed

8 tasks

mikiquantum added 3 commits February 7, 2022 15:05

updates to v0.9.16

bbec89a

fix conflicts

02e3637

fix docker compose

45546ec

mikiquantum merged commit 0efdc9e into parachain Feb 8, 2022

mikiquantum deleted the rtu5 branch February 8, 2022 00:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Altair Runtime Upgrade 5 + Polkadot upgrade to v0.9.16 #611

Altair Runtime Upgrade 5 + Polkadot upgrade to v0.9.16 #611

mikiquantum commented Jan 29, 2022 •

edited

Loading

mikiquantum Jan 29, 2022

mikiquantum Jan 29, 2022

branan Jan 31, 2022

NunoAlexandre left a comment

mikiquantum Jan 30, 2022

mustermeiszer left a comment

mustermeiszer Jan 30, 2022

mustermeiszer Jan 30, 2022

branan Jan 31, 2022

mustermeiszer Jan 30, 2022

branan Jan 31, 2022

mustermeiszer Jan 30, 2022

mikiquantum Jan 31, 2022

mustermeiszer Jan 30, 2022

branan Jan 31, 2022

mikiquantum Jan 31, 2022

mustermeiszer Jan 31, 2022

mustermeiszer Jan 30, 2022

mustermeiszer Jan 30, 2022

mikiquantum Jan 31, 2022

branan Jan 31, 2022

branan Jan 31, 2022

mikiquantum Jan 31, 2022

mikiquantum Jan 31, 2022

mustermeiszer Jan 31, 2022

mikiquantum Jan 31, 2022

branan commented Jan 31, 2022

NunoAlexandre commented Jan 31, 2022

Altair Runtime Upgrade 5 + Polkadot upgrade to v0.9.16 #611

Altair Runtime Upgrade 5 + Polkadot upgrade to v0.9.16 #611

Conversation

mikiquantum commented Jan 29, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NunoAlexandre left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mustermeiszer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

branan commented Jan 31, 2022

NunoAlexandre commented Jan 31, 2022

mikiquantum commented Jan 29, 2022 •

edited

Loading