Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase: bump k8s.io/klog/v2 from 2.10.0 to 2.30.0 #2590

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 25, 2021

Bumps k8s.io/klog/v2 from 2.10.0 to 2.30.0.

Release notes

Sourced from k8s.io/klog/v2's releases.

Prepare klog release for Kubernetes v1.23 (take 2)

What's Changed

New Contributors

Full Changelog: kubernetes/klog@v2.20.0...v2.30.0

Prepare klog release for Kubernetes v1.23

Changes are here : kubernetes/klog@v2.10.0...v2.20.0

since we moved to logr v1.0.0, there are incompatible changes:

- klogger.Enabled: changed from func() bool to func(int) bool
- klogger.Info: changed from func(string, ...interface{}) to func(int, string, ...interface{})
- klogger.V: removed
- klogger.WithCallDepth: changed from func(int) github.com/go-logr/logr.Logger to func(int) github.com/go-logr/logr.LogSink
- klogger.WithName: changed from func(string) github.com/go-logr/logr.Logger to func(string) github.com/go-logr/logr.LogSink
- klogger.WithValues: changed from func(...interface{}) github.com/go-logr/logr.Logger to func(...interface{}) github.com/go-logr/logr.LogSink

83653a6deebf Update to newest versions of golang 1.17.x d648c2e42d30 fix file-based filtering symbolization 8ee3d652c96b export ClearLogger 4171f3c1be1b Switching to logr tag v1.0.0 9ab3c2b56cb2 add serathius as approvers of klog

Commits
  • 9ad2462 Merge pull request #266 from pohly/object-marshaler
  • f351023 custom marshaler for ObjectRef
  • 331d232 Merge pull request #265 from luyou86/bugfix-logcheck-exit-function
  • f9de652 Fix logcheck exit function
  • f8e668d Merge pull request #260 from dims/update-to-newest-versions-of-golang-1.17
  • 83653a6 Update to newest versions of golang 1.17.x
  • d648c2e fix file-based filtering symbolization
  • e1f317b Merge pull request #250 from yuzhiquan/add-serathius-approver
  • 74b1b2a Merge pull request #257 from pohly/clear-logger
  • 8ee3d65 export ClearLogger
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Depends-On: #2639


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the rebase update the version of an external component label Oct 25, 2021
@nixpanic
Copy link
Member

nixpanic commented Nov 1, 2021

This depends on kubernetes-sigs/controller-runtime#1593 . We'll get to this when a new release of controller-runtime is available.

@nixpanic nixpanic closed this Nov 1, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 1, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/k8s.io/klog/v2-2.30.0 branch November 1, 2021 09:42
@nixpanic
Copy link
Member

@dependabot reopen

#2639 includes an update for controller-runtime, and it updates the logging dependencies. Hopefully the conflicts will be resolved now.

@dependabot dependabot bot reopened this Nov 17, 2021
@dependabot dependabot bot restored the dependabot/go_modules/k8s.io/klog/v2-2.30.0 branch November 17, 2021 15:07
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 22, 2021

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@mergify mergify bot added ci/skip/e2e skip running e2e CI jobs component/build Issues and PRs related to compiling Ceph-CSI component/testing Additional test cases or CI work labels Nov 23, 2021
@nixpanic nixpanic removed component/testing Additional test cases or CI work component/build Issues and PRs related to compiling Ceph-CSI ci/skip/e2e skip running e2e CI jobs labels Nov 23, 2021
@mergify mergify bot added ci/skip/e2e skip running e2e CI jobs component/build Issues and PRs related to compiling Ceph-CSI component/testing Additional test cases or CI work labels Nov 23, 2021
@nixpanic nixpanic removed component/testing Additional test cases or CI work component/build Issues and PRs related to compiling Ceph-CSI ci/skip/e2e skip running e2e CI jobs labels Nov 23, 2021
@mergify mergify bot added ci/skip/e2e skip running e2e CI jobs component/build Issues and PRs related to compiling Ceph-CSI component/testing Additional test cases or CI work labels Nov 23, 2021
@nixpanic nixpanic removed component/testing Additional test cases or CI work component/build Issues and PRs related to compiling Ceph-CSI ci/skip/e2e skip running e2e CI jobs labels Nov 23, 2021
@nixpanic
Copy link
Member

The issues have not been resolved yet, maybe kubernetes-sigs/controller-runtime#1709 was not sufficient and something else needs updating too?

dependabot bot and others added 2 commits November 24, 2021 08:13
Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog) from 2.10.0 to 2.30.0.
- [Release notes](https://github.com/kubernetes/klog/releases)
- [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md)
- [Commits](kubernetes/klog@v2.10.0...v2.30.0)

---
updated-dependencies:
- dependency-name: k8s.io/klog/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
This makes it possible to update k8s.io/klog to the most recent version.
There is no intention of merging this, it is only used to confirm that
updating controller-runtime to a more recent version is required.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
@nixpanic
Copy link
Member

The issues have not been resolved yet, maybe kubernetes-sigs/controller-runtime#1709 was not sufficient and something else needs updating too?

That PR is only available in controller-runtime v0.11.0-beta.0 (latest beta)...

@nixpanic nixpanic marked this pull request as draft November 24, 2021 07:31
@nixpanic nixpanic force-pushed the dependabot/go_modules/k8s.io/klog/v2-2.30.0 branch from 5355ec0 to b563228 Compare November 24, 2021 07:32
@mergify mergify bot closed this in #2699 Dec 13, 2021
@dependabot dependabot bot deleted the dependabot/go_modules/k8s.io/klog/v2-2.30.0 branch December 13, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebase update the version of an external component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants