rebase: update kubernetes to v1.23.0 #2699

Madhu-1 · 2021-12-08T13:51:54Z

updating go dependency to latest kubernetes released version i.e v1.23.0

closes #2698
closes #2590
depends-on: #2703

note:- other dependencies are auto-updated when I ran go mod commands

Signed-off-by: Madhu Rajanna madhupr007@gmail.com

go.mod

Madhu-1 · 2021-12-09T06:46:32Z

/retest all

nixpanic

Looks good to me, but something causes building e2e.test to fail now:

go test -tags=pacific -mod=vendor -c ./e2e
# sigs.k8s.io/json/internal/golang/encoding/json
vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1255:18: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)

Madhu-1 · 2021-12-09T10:06:45Z

ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no root@n61.gusty.ci.centos.org 'cd /opt/build/go/src/github.com/ceph/ceph-csi && make containerized-build CONTAINER_CMD=podman TARGET=e2e.test ENV_CSI_IMAGE_NAME=registry-ceph-csi.apps.ocp.ci.centos.org/ceph-csi USE_PULLED_IMAGE=yes'
Warning: Permanently added 'n61.gusty.ci.centos.org,172.19.2.189' (ECDSA) to the list of known hosts.
cephcsi image settings: registry-ceph-csi.apps.ocp.ci.centos.org/ceph-csi version canary
podman inspect -f '{{.Id}}' registry-ceph-csi.apps.ocp.ci.centos.org/ceph-csi:devel > .devel-container-id

@nixpanic CI is failing because it's using the older devel image which is built for golang 1.16 we need a new image to be pushed to the CI registry for CI to pass. can you please help with that

go.mod

nixpanic · 2021-12-09T11:09:34Z

I think images are rebuilt after a PR has been merged. See https://jenkins-ceph-csi.apps.ocp.ci.centos.org/job/build-images/

However, if a PR changes the build.env file, it should not download the pre-built container image, but build a new one from scratch... If that is not working for some reason, we need to fix that.

nixpanic · 2021-12-09T12:13:06Z

I think images are rebuilt after a PR has been merged. See https://jenkins-ceph-csi.apps.ocp.ci.centos.org/job/build-images/

However, if a PR changes the build.env file, it should not download the pre-built container image, but build a new one from scratch... If that is not working for some reason, we need to fix that.

Ah, it seems this is not done for all CI jobs...

ceph-csi/containerized-tests.groovy

Lines 96 to 102 in d351e00

    
           def rebuild_test_container = sh( 
        
           	script: "cd ~/build/ceph-csi && \${OLDPWD}/scripts/container-needs-rebuild.sh test origin/${git_since}", 
        
           	returnStatus: true) 
        
           def rebuild_devel_container = sh( 
        
           	script: "cd ~/build/ceph-csi && \${OLDPWD}/scripts/container-needs-rebuild.sh devel origin/${git_since}", 
        
           	returnStatus: true)

It might be easier to send a PR updating Golang, get that merged so the container-images are rebuilt. And then update the Kubernetes dependency.

Madhu-1 · 2021-12-10T05:08:25Z

#2703 is to update the golang version to 1.17 once it's merged will rebase this one.

nixpanic · 2021-12-10T07:14:11Z

When this PR is merged, #2590 can be closed as well.

nixpanic · 2021-12-10T07:16:40Z

build.env

@@ -16,7 +16,7 @@ BASE_IMAGE=docker.io/ceph/ceph:v16
 CEPH_VERSION=octopus

 # standard Golang options
-GOLANG_VERSION=1.16.4
+GOLANG_VERSION=1.17.4


This obviously is part of #2703 already, so a rebase will be needed. Setting depends-on: #2703 in the description so that Mergify should pick it up automatically.

nixpanic · 2021-12-10T07:25:26Z

scripts/Dockerfile.test

@@ -38,6 +39,9 @@ RUN source /build.env \
    && dnf -y update \
    && dnf -y clean all \
    && gem install mdl \
+    && mkdir -p ${GOROOT} \
+    && curl https://storage.googleapis.com/golang/go${GOLANG_VERSION}.linux-amd64.tar.gz  \


This makes me sad, it breaks on non-amd64 architectures... But I also do not know of a better way to do this, current Fedora 35 (:latest) has golang-1.16.x 😞

yes, I borrowed it from https://github.com/ceph/ceph-csi/blob/devel/scripts/Dockerfile.devel#L15. #2707 is for tracking

Madhu-1 · 2021-12-10T07:39:23Z

@Rakshith-R you have requested changes. PTAL

Pull request has been modified.

mergify · 2021-12-10T10:12:10Z

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

updating go dependency to latest kubernetes released version i.e v1.23.0 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

as go-sum is auto generated, ignore checking codespell on this file. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

updating the depencendices to golang 1.17.5 release Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

As we are updating the cephcsi main repo to golang 1.17, updating the action package to golang 1.17 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

installed the go version specified in build.env in the test docker image. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

currently getting find command not found and xargs command not found when we run the dockerfile.test. installing findutils to fix it. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

as part of running `go mod tidy` the unused k8s.io/utils is removed from the vendor directory. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

Pull request has been modified.

Madhu-1 · 2021-12-10T10:51:03Z

X Exiting due to GUEST_PROVISION: Failed to start host: creating host: create: Error creating machine: Error in driver during machine creation: IP not available after waiting: machine minikube didn't return IP after 1 minute

CI failure

Madhu-1 · 2021-12-10T10:51:21Z

/retest ci/centos/upgrade-tests-rbd

Madhu-1 · 2021-12-13T05:23:08Z

/retest ci/centos/upgrade-tests-cephfs

Madhu-1 · 2021-12-13T05:23:40Z

X Exiting due to GUEST_PROVISION: Failed to start host: creating host: create: Error creating machine: Error in driver during machine creation: IP not available after waiting: machine minikube didn't return IP after 1 minute

failed due to above error

Madhu-1 · 2021-12-13T07:30:23Z

@Rakshith-R can you please bring your approval back on this one?

mergify bot added the rebase update the version of an external component label Dec 8, 2021

nixpanic reviewed Dec 8, 2021

View reviewed changes

go.mod Show resolved Hide resolved

Madhu-1 force-pushed the update-kube1.23 branch from f248ec9 to 6f80b27 Compare December 9, 2021 05:10

Madhu-1 added the ci/skip/e2e skip running e2e CI jobs label Dec 9, 2021

Madhu-1 force-pushed the update-kube1.23 branch 4 times, most recently from cd7fcc6 to 58798ce Compare December 9, 2021 06:11

Madhu-1 removed the ci/skip/e2e skip running e2e CI jobs label Dec 9, 2021

Madhu-1 force-pushed the update-kube1.23 branch from 58798ce to 7b58502 Compare December 9, 2021 06:15

Madhu-1 added ci/skip/e2e skip running e2e CI jobs and removed ci/skip/e2e skip running e2e CI jobs labels Dec 9, 2021

Madhu-1 requested a review from nixpanic December 9, 2021 06:48

nixpanic added the component/build Issues and PRs related to compiling Ceph-CSI label Dec 9, 2021

nixpanic requested changes Dec 9, 2021

View reviewed changes

Rakshith-R requested changes Dec 9, 2021

View reviewed changes

go.mod Show resolved Hide resolved

Madhu-1 requested review from Rakshith-R and nixpanic December 9, 2021 10:15

Madhu-1 mentioned this pull request Dec 10, 2021

rebase: update golang version to 1.17.5 #2703

Merged

nixpanic previously approved these changes Dec 10, 2021

View reviewed changes

Madhu-1 force-pushed the update-kube1.23 branch from f34aa5b to ab29428 Compare December 10, 2021 07:39

Rakshith-R previously approved these changes Dec 10, 2021

View reviewed changes

nixpanic previously approved these changes Dec 10, 2021

View reviewed changes

Madhu-1 added 7 commits December 10, 2021 15:47

rebase: update kubernetes to v1.23.0

a83d7e5

updating go dependency to latest kubernetes released version i.e v1.23.0 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

ci: ignore go.sum from codespell check

3b9d8db

as go-sum is auto generated, ignore checking codespell on this file. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

ci: update golang dependencies to 1.17.5 release

773c7c0

updating the depencendices to golang 1.17.5 release Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

ci: update action go.mod to 1.17

978232f

As we are updating the cephcsi main repo to golang 1.17, updating the action package to golang 1.17 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

ci: install go version specified in build.env

9215290

installed the go version specified in build.env in the test docker image. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

ci: install findutils in dockerfile.test

f2748a3

currently getting find command not found and xargs command not found when we run the dockerfile.test. installing findutils to fix it. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

cleanup: remove k8s.io/utils from vendor

69023f8

as part of running `go mod tidy` the unused k8s.io/utils is removed from the vendor directory. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

Madhu-1 force-pushed the update-kube1.23 branch from ab29428 to 69023f8 Compare December 10, 2021 10:21

Madhu-1 requested review from nixpanic and Rakshith-R December 10, 2021 10:22

nixpanic approved these changes Dec 10, 2021

View reviewed changes

Madhu-1 added the ci/retry/e2e Label to retry e2e retesting on approved PR's label Dec 10, 2021

Madhu-1 requested a review from a team December 13, 2021 05:23

Rakshith-R approved these changes Dec 13, 2021

View reviewed changes

mergify bot merged commit b1a3b02 into ceph:devel Dec 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rebase: update kubernetes to v1.23.0 #2699

rebase: update kubernetes to v1.23.0 #2699

Madhu-1 commented Dec 8, 2021 •

edited

Loading

Madhu-1 commented Dec 9, 2021

nixpanic left a comment

Madhu-1 commented Dec 9, 2021

nixpanic commented Dec 9, 2021

nixpanic commented Dec 9, 2021

Madhu-1 commented Dec 10, 2021

nixpanic commented Dec 10, 2021

nixpanic Dec 10, 2021

nixpanic Dec 10, 2021

Madhu-1 Dec 10, 2021

Madhu-1 commented Dec 10, 2021

mergify bot commented Dec 10, 2021

Madhu-1 commented Dec 10, 2021

Madhu-1 commented Dec 10, 2021

Madhu-1 commented Dec 13, 2021

Madhu-1 commented Dec 13, 2021

Madhu-1 commented Dec 13, 2021

rebase: update kubernetes to v1.23.0 #2699

rebase: update kubernetes to v1.23.0 #2699

Conversation

Madhu-1 commented Dec 8, 2021 • edited Loading

Madhu-1 commented Dec 9, 2021

nixpanic left a comment

Choose a reason for hiding this comment

Madhu-1 commented Dec 9, 2021

nixpanic commented Dec 9, 2021

nixpanic commented Dec 9, 2021

Madhu-1 commented Dec 10, 2021

nixpanic commented Dec 10, 2021

nixpanic Dec 10, 2021

Choose a reason for hiding this comment

nixpanic Dec 10, 2021

Choose a reason for hiding this comment

Madhu-1 Dec 10, 2021

Choose a reason for hiding this comment

Madhu-1 commented Dec 10, 2021

mergify bot commented Dec 10, 2021

Madhu-1 commented Dec 10, 2021

Madhu-1 commented Dec 10, 2021

Madhu-1 commented Dec 13, 2021

Madhu-1 commented Dec 13, 2021

Madhu-1 commented Dec 13, 2021

Madhu-1 commented Dec 8, 2021 •

edited

Loading