rebase: update golang version to 1.17.5 #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
added
Backport
|
adding backport label as we need to support 3.4 for a while |
Could you explain why this is needed for 3.4? We usually don't backport features, only bugfixes... |
nixpanic
requested changes
Dec 10, 2021
If you want to keep that as part of #2699, that is fine too. |
not a blocker for now. will adjust when updating the go.mod even with 1.16 in go.mod everything works fine. |
yes, correct this is not needed. dropping it |
nixpanic
approved these changes
Dec 10, 2021
|
@Mergifyio rebase |
This commit updates the golang to the latest available release i.e 1.17.5 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
adding protobuf to go.mod to fix `from implicitly required module to add missing requirement` error Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
✅ Branch has been successfully rebased |
Madhu-1
force-pushed
the
update-go-1.17.5
branch
from
f806344
to
469b277
Compare
Yuggupta27
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the golang to the latest available release i.e 1.17.5
Updating golang to 1.7.x will unblock #2699
Signed-off-by: Madhu Rajanna madhupr007@gmail.com