-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase: update golang version to 1.17.5 #2703
Conversation
adding backport label as we need to support 3.4 for a while |
Could you explain why this is needed for 3.4? We usually don't backport features, only bugfixes... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the golang version in go.mod needs to be adjusted too?
If you want to keep that as part of #2699, that is fine too. |
not a blocker for now. will adjust when updating the go.mod even with 1.16 in go.mod everything works fine. |
yes, correct this is not needed. dropping it |
@Mergifyio rebase |
This commit updates the golang to the latest available release i.e 1.17.5 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
adding protobuf to go.mod to fix `from implicitly required module to add missing requirement` error Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
✅ Branch has been successfully rebased |
f806344
to
469b277
Compare
This commit updates the golang to the latest available release i.e 1.17.5
Updating golang to 1.7.x will unblock #2699
Signed-off-by: Madhu Rajanna madhupr007@gmail.com