-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging: reduce systemd related errors while mounting #3225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mount-utils package where we can, the number of confising logs get reduced.
-> confusing ..
85c18f2
to
83142ac
Compare
lgtm. if you can correct the commitlint failure. |
83142ac
to
935078b
Compare
@Mergifyio rebase |
There are regular reports that identify a non-error as the cause of failures. The Kubernetes mount-utils package has detection for systemd based environments, and if systemd is unavailable, the following error is logged: Cannot run systemd-run, assuming non-systemd OS systemd-run output: System has not been booted with systemd as init system (PID 1). Can't operate. Failed to create bus connection: Host is down, failed with: exit status 1 Because of the `failed` and `exit status 1` error message, users might assume that the mounting failed. This does not need to be the case. The container-images that the Ceph-CSI projects provides, do not use systemd, so the error will get logged with each mount attempt. By using the newer MountSensitiveWithoutSystemd() function from the mount-utils package where we can, the number of confusing logs get reduced. Signed-off-by: Niels de Vos <ndevos@redhat.com>
✅ Branch has been successfully rebased |
935078b
to
73c5d8e
Compare
/retest ci/centos/k8s-e2e-external-storage/1.23 |
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
/retest ci/centos/mini-e2e/k8s-1.21 |
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
There are regular reports that identify a non-error as the cause of
failures. The Kubernetes mount-utils package has detection for systemd
based environments, and if systemd is unavailable, the following error
is logged:
Because of the
failed
andexit status 1
error message, users mightassume that the mounting failed. This does not need to be the case. The
container-images that the Ceph-CSI projects provides, do not use
systemd, so the error will get logged with each mount attempt.
By using the newer MountSensitiveWithoutSystemd() function from the
mount-utils package where we can, the number of confusing logs get
reduced.
See-also: #2890
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>
: retest the<job-name>
after unrelatedfailure (please report the failure too!)
/retest all
: run this in case the CentOS CI failed to start/report any testprogress or results