util: use k8s.io/mount-utils/NewWithoutSystemd() to prevent logging #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CephFS was addressed with #3225, and with this PR the fixes are addressed for RBD. Here the log of the |
nixpanic
added
component/rbd
Rakshith-R
approved these changes
Aug 3, 2022
Madhu-1
approved these changes
Aug 3, 2022
|
@Mergifyio rebase |
kubernetes/kubernetes#111083 has been merged and synced into k8s.io/mount-utils. This should remove any systemd log messages while calling NodeStageVolume and NodeGetVolumeStats. Signed-off-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
NewWithoutSystemd() has been introduced in the k8s.io/mount-utils package so that systemd is not called while executing functions. This offers consumers the ability to prevent confusing and scary messages from getting logged. See-also: kubernetes/kubernetes#111218 Signed-off-by: Niels de Vos <ndevos@redhat.com>
IsNotMountPoint() is deprecated and Mounter.IsMountPoint() is recommended to be used instead. Reported-by: golangci/staticcheck Signed-off-by: Niels de Vos <ndevos@redhat.com>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
logging/no-systemd
branch
from
eeac252
to
8aa3ef4
Compare
|
/retest ci/centos/k8s-e2e-external-storage/1.23 |
|
/retest ci/centos/k8s-e2e-external-storage/1.22 |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewWithoutSystemd() has been introduced in the k8s.io/mount-utils
package so that systemd is not called while executing functions. This
offers consumers the ability to prevent confusing and scary messages
from getting logged.
See-also: kubernetes/kubernetes#111218
Fixes: #3246
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results