Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: use k8s.io/mount-utils/NewWithoutSystemd() to prevent logging #3281

Merged
merged 4 commits into from
Aug 4, 2022
Merged

util: use k8s.io/mount-utils/NewWithoutSystemd() to prevent logging #3281

merged 4 commits into from
Aug 4, 2022

Commits on Aug 4, 2022

  1. rebase: update k8s.io/mount-utils to current master 

    kubernetes/kubernetes#111083 has been merged and synced into
k8s.io/mount-utils. This should remove any systemd log messages while
calling NodeStageVolume and NodeGetVolumeStats.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
    @nixpanic @mergify
    nixpanic authored and mergify[bot] committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    9ab4b51 View commit details
    Browse the repository at this point in the history

  2. rbd: use IsLikelyNotMountPoint() to prevent systemd log messages 

    Signed-off-by: Niels de Vos <ndevos@redhat.com>
    @nixpanic @mergify
    nixpanic authored and mergify[bot] committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    2b9b43f View commit details
    Browse the repository at this point in the history

  3. util: use k8s.io/mount-utils/NewWithoutSystemd() to prevent logging 

    NewWithoutSystemd() has been introduced in the k8s.io/mount-utils
package so that systemd is not called while executing functions. This
offers consumers the ability to prevent confusing and scary messages
from getting logged.

See-also: kubernetes/kubernetes#111218
Signed-off-by: Niels de Vos <ndevos@redhat.com>
    @nixpanic @mergify
    nixpanic authored and mergify[bot] committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    208e448 View commit details
    Browse the repository at this point in the history

  4. rebase: k8s.io/mount-utils/IsNotMountPoint() is deprecated 

    IsNotMountPoint() is deprecated and Mounter.IsMountPoint() is
recommended to be used instead.

Reported-by: golangci/staticcheck
Signed-off-by: Niels de Vos <ndevos@redhat.com>
    @nixpanic @mergify
    nixpanic authored and mergify[bot] committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    8aa3ef4 View commit details
    Browse the repository at this point in the history