Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: adjust e2e test to run on kubernetes 1.25 #3362

Merged
merged 4 commits into from
Oct 26, 2022
Merged

e2e: adjust e2e test to run on kubernetes 1.25 #3362

merged 4 commits into from
Oct 26, 2022

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Sep 2, 2022 •
edited by nixpanic
Loading

removed podsecurity feature-gate and adjusted e2e tests to use privileged pod security for the e2e namespace

Depends-On: #3365

@mergify mergify bot added the component/testing Additional test cases or CI work label Sep 2, 2022
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 2, 2022

This is a replacement for #3359 to allow running tests on kubernetes 1.25 and will adjust all pod security and pod templates later to not run e2e with privileged access

@Madhu-1 Madhu-1 requested review from a team September 2, 2022 06:22
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 2, 2022

/retest ci/centos/upgrade-tests-cephfs

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 5, 2022

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2022

rebase

✅ Branch has been successfully rebased

Rakshith-R
Rakshith-R previously approved these changes Sep 5, 2022
View reviewed changes
@nixpanic
Copy link
Member

nixpanic commented Sep 5, 2022

/test ci/centos/mini-e2e/k8s-1.25

@nixpanic
Copy link
Member

nixpanic commented Sep 5, 2022

/test ci/centos/mini-e2e-helm/k8s-1.25

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 5, 2022

@nixpanic, we dont have a CI job for 1.25 yet. let me send PR for it.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 5, 2022

#3365 should allow us to run tests on 1.25

@nixpanic
Copy link
Member

nixpanic commented Sep 5, 2022

/test ci/centos/mini-e2e/k8s-1.25

@mergify mergify bot dismissed Rakshith-R’s stale review September 6, 2022 05:11

Pull request has been modified.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 6, 2022

#3372 is required as Rook deployment fails on kubernetes 1.25

@nixpanic
Copy link
Member

nixpanic commented Sep 6, 2022

#3372 is required as Rook deployment fails on kubernetes 1.25

Note that syncing images is done nightly, so the image will be available tomorrow.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 7, 2022

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2022

rebase

✅ Branch has been successfully rebased

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 7, 2022

/test ci/centos/mini-e2e/k8s-1.25

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 7, 2022

/test ci/centos/mini-e2e-helm/k8s-1.25

1 similar comment
@nixpanic
Copy link
Member

nixpanic commented Sep 7, 2022

/test ci/centos/mini-e2e-helm/k8s-1.25

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 7, 2022

/retest all

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 13, 2022

/retest ci/centos/mini-e2e/k8s-1.25

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 13, 2022

  • ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no root@n9.dusty.ci.centos.org 'podman pull --authfile=~/.podman-auth.json registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph:v1.10.0 && podman tag registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph:v1.10.0 rook/ceph:v1.10.0 docker.io/rook/ceph:v1.10.0'
    Trying to pull registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph:v1.10.0...
    Error: initializing source docker://registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph:v1.10.0: reading manifest v1.10.0 in registry-ceph-csi.apps.ocp.ci.centos.org/rook/ceph: manifest unknown: manifest unknown
    script returned exit code 125

@nixpanic looks like the images are not pushed to internal registry yet?

@nixpanic nixpanic mentioned this pull request Sep 14, 2022
Closed
@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.24

@github-actions
Copy link

/test ci/centos/upgrade-tests-cephfs

@github-actions
Copy link

/test ci/centos/upgrade-tests-rbd

@Madhu-1 @mergify
ci: remove podsecurity feature-gate
9a43cd2 
remove the podsecurity feature-gate
from minikube.sh, because of it
kubernetes 1.25.0 deployment is failing

fixes: ceph#3358

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1 @mergify
e2e: set privileged as pod security enforcement level
02a7b78 
setting privileged as pod security enforcement level
to run test on kubernetes 1.25

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1 @mergify
e2e: fix panic when checking error
b3ac1be 
fix panic during error handling

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1 @mergify
ci: use rook v1.10.4 release
b521845 
Rook v1.10.4 supports deployment
of Rook on Kubernetes 1.25 or else
Rook deployment will fail.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2022

rebase

✅ Branch has been successfully rebased

@Madhu-1 Madhu-1 added ok-to-test Label to trigger E2E tests and removed ok-to-test Label to trigger E2E tests labels Oct 26, 2022
@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.22

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.23

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.24

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.22

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.22

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.24

@github-actions
Copy link

/test ci/centos/upgrade-tests-cephfs

@github-actions
Copy link

/test ci/centos/upgrade-tests-rbd

@mergify mergify bot merged commit 5aaa9bf into ceph:devel Oct 26, 2022
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Oct 27, 2022

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2022

rebase

☑️ Nothing to do

  • -closed [:pushpin: rebase requirement]
  • any of:
    • #commits-behind>0 [:pushpin: rebase requirement]
    • -linear-history [:pushpin: rebase requirement]

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Oct 27, 2022

@Mergifyio refresh

@mergify mergify bot mentioned this pull request Oct 27, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2022

refresh

✅ Pull request refreshed

@Madhu-1 Madhu-1 mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
component/testing Additional test cases or CI work ok-to-test Label to trigger E2E tests ready-to-merge This PR is ready to be merged and it doesn't need second review (backports only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to create kubernetes 1.25.0 cluster with minikube.sh
3 participants
@Madhu-1 @nixpanic @Rakshith-R