ci: script changes to run minikube with none driver #3415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install required crio to run minikube with none driver and added if check to exclude minikube argements which doesnot required for none driver. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Madhu-1
added
the
ci/skip/multi-arch-build
|
I think you also need to modify https://github.com/ceph/ceph-csi/blob/ci/centos/single-node-k8s.sh |
Yes for now hardcoding the script to start cluster with none driver for testing, if everything goes well i move some installation and configurtion to above script |
Madhu-1
force-pushed
the
run-none
branch
5 times, most recently
from
782acd8
to
bdcc708
Compare
nixpanic
reviewed
Oct 6, 2022
scripts/minikube.sh
Outdated
| EXTRA_MINIKUBE_ARGS=${EXTRA_MINIKUBE_ARGS:-"--container-runtime=cri-o"} | ||
|
|
||
| function install_crio() { | ||
| dnf install jq conntrack docker -y |
There was a problem hiding this comment.
please do not use Docker, use Podman instead.
Isn't there a repository that provides CRIO RPMs?
Madhu-1
force-pushed
the
run-none
branch
3 times, most recently
from
75fd672
to
ef372c1
Compare
|
/test ci/centos/k8s-e2e-external-storage/1.22 |
1 similar comment
|
/test ci/centos/k8s-e2e-external-storage/1.22 |
|
/retest ci/centos/mini-e2e/k8s-1.22 |
Madhu-1
force-pushed
the
run-none
branch
10 times, most recently
from
b72e8b1
to
a85765c
Compare
|
/retest ci/centos/mini-e2e/k8s-1.22 |
|
@Mergifyio rebase |
☑️ Nothing to do
|
Madhu-1
force-pushed
the
run-none
branch
3 times, most recently
from
b2f2145
to
9fbf360
Compare
test only change to check everything works fine for the none driver Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Oct 7, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: ceph#3419 Closes: ceph#3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Oct 7, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: ceph#3419 Closes: ceph#3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Oct 11, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: ceph#3419 Closes: ceph#3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Oct 12, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: ceph#3419 Closes: ceph#3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Oct 12, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: ceph#3419 Closes: ceph#3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Oct 12, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: ceph#3419 Closes: ceph#3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: #3419 Closes: #3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: #3419 Closes: #3415 Signed-off-by: Niels de Vos <ndevos@redhat.com> (cherry picked from commit 0cba724)
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: #3419 Closes: #3415 Signed-off-by: Niels de Vos <ndevos@redhat.com> (cherry picked from commit 0cba724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install required crio to run minikube with none driver and added if check to exclude minikube arguments which doesnot required for none driver.
Signed-off-by: Madhu Rajanna madhupr007@gmail.com