-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use VM_DRIVER=podman for AWS virtual-machines #3419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Oct 7, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: ceph#3419 Closes: ceph#3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Oct 7, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: ceph#3419 Closes: ceph#3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
Rakshith-R
approved these changes
Oct 10, 2022
Madhu-1
approved these changes
Oct 10, 2022
With the CentOS CI machines moving to AWS EC2 virtual-machines, there is no option to run minikube with a VM anymore. Instead, run minikube with the Podman driver and partition the extra xvdb EBS volume into three pieces. Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Oct 11, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: ceph#3419 Closes: ceph#3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Oct 12, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: ceph#3419 Closes: ceph#3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Oct 12, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: ceph#3419 Closes: ceph#3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Oct 12, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: ceph#3419 Closes: ceph#3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: #3419 Closes: #3415 Signed-off-by: Niels de Vos <ndevos@redhat.com>
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: #3419 Closes: #3415 Signed-off-by: Niels de Vos <ndevos@redhat.com> (cherry picked from commit 0cba724)
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2022
When running on AWE EC2 virtual-machines, we'll use Podman instead of installing a VM. The "none" driver might work as well, but it requires additional dependencies to be installed, which may change over time with new minikube or Kubernetes releases. Hopefully the Podman driver is less affected with changes in dependencies. Depends-on: #3419 Closes: #3415 Signed-off-by: Niels de Vos <ndevos@redhat.com> (cherry picked from commit 0cba724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the CentOS CI machines moving to AWS EC2 virtual-machines, there is no option to run minikube with a VM anymore. Instead, run minikube with the Podman driver and partition the extra xvdb EBS volume into three pieces.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>
: retest the<job-name>
after unrelatedfailure (please report the failure too!)
/retest all
: run this in case the CentOS CI failed to start/report any testprogress or results