cephfs: skip expand for BackingSnapshot volume #3586
Conversation
We should not call ExpandVolume for the BackingSnapshot subvolume as there wont be any real subvolume created for it and even if we call it the ExpandVolume will fail fail as there is no real subvolume exists. This commits fixes by adjusting the `if` check to ensure that ExpandVolume will only be called either the VolumeRequest is to create from a snapshot or volume and BackingSnapshot is not true. sample code here https://go.dev/play/p/PI2tNii5tTg Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
|
/lgtm |
|
/test ci/centos/k8s-e2e-external-storage/1.23 |
|
/test ci/centos/k8s-e2e-external-storage/1.24 |
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.23 |
|
/test ci/centos/mini-e2e-helm/k8s-1.24 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.23 |
|
/test ci/centos/mini-e2e/k8s-1.24 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
mergify
bot
added
ok-to-test
|
/test ci/centos/k8s-e2e-external-storage/1.23 |
|
/test ci/centos/k8s-e2e-external-storage/1.24 |
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.23 |
|
/test ci/centos/mini-e2e-helm/k8s-1.24 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.23 |
|
/test ci/centos/mini-e2e/k8s-1.24 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
We should not call ExpandVolume for the BackingSnapshot subvolume as their wont be any real subvolume created for it, and even if we call it, the ExpandVolume will fail as there is no real subvolume that exists.
This commits fixes by adjusting the
ifcheck to ensure that ExpandVolume will only be called either theVolumeRequest is to create from a snapshot or volume, and BackingSnapshot is not true.
sample code here https://go.dev/play/p/PI2tNii5tTg
Signed-off-by: Madhu Rajanna madhupr007@gmail.com