Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: free snapshot resources after allocation #4514

Merged
merged 5 commits into from
Mar 28, 2024
Merged

rbd: free snapshot resources after allocation #4514

merged 5 commits into from
Mar 28, 2024

Conversation

nixpanic
Copy link
Member

Just like GenVolFromVolID() the genSnapFromSnapID() function can return
a snapshot. There is no need to allocated an empty snapshot and pass
that to the genSnapFromSnapID() function.

With this change, it is visible that not all snapshot objects are free'd correctly after they were allocated.
It is possible that some connections to the Ceph cluster were never
closed. This does not need to be a noticeable problem, as connections
are re-used where possible, but it isn't clean either.

@mergify mergify bot added the component/rbd Issues related to RBD label Mar 21, 2024
Madhu-1
Madhu-1 previously approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpanic nixpanic requested a review from a team March 21, 2024 12:31
yati1998
yati1998 previously approved these changes Mar 21, 2024
View reviewed changes
@nixpanic
Copy link
Member Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 21, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Mar 21, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Mar 21, 2024
@nixpanic
Copy link
Member Author

oh no, interesting failure!

  I0321 15:32:43.841709       1 utils.go:198] ID: 40 Req-ID: 0001-0024-4a93465d-9d6b-49d5-a38e-8fb38ed70ee8-0000000000000002-1593e684-c8bd-4080-8910-009e5519ec7b GRPC call: /csi.v1.Controller/DeleteSnapshot
  I0321 15:32:43.841827       1 utils.go:199] ID: 40 Req-ID: 0001-0024-4a93465d-9d6b-49d5-a38e-8fb38ed70ee8-0000000000000002-1593e684-c8bd-4080-8910-009e5519ec7b GRPC request: {"secrets":"***stripped***","snapshot_id":"0001-0024-4a93465d-9d6b-49d5-a38e-8fb38ed70ee8-0000000000000002-1593e684-c8bd-4080-8910-009e5519ec7b"}
  E0321 15:32:43.841920       1 rbd_util.go:963] ID: 40 Req-ID: 0001-0024-4a93465d-9d6b-49d5-a38e-8fb38ed70ee8-0000000000000002-1593e684-c8bd-4080-8910-009e5519ec7b error decoding snapshot ID (failed to decode CSI identifier, string underflow) ()
  E0321 15:32:43.841956       1 utils.go:203] ID: 40 Req-ID: 0001-0024-4a93465d-9d6b-49d5-a38e-8fb38ed70ee8-0000000000000002-1593e684-c8bd-4080-8910-009e5519ec7b GRPC error: rpc error: code = Internal desc = failed to decode CSI identifier, string underflow

iPraveenParihar
iPraveenParihar requested changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@iPraveenParihar iPraveenParihar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^ requested changes in above comment.

@mergify mergify bot dismissed stale reviews from yati1998 and Madhu-1 March 22, 2024 08:15

Pull request has been modified.

Madhu-1
Madhu-1 previously approved these changes Mar 22, 2024
View reviewed changes
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Mar 26, 2024
@nixpanic
Copy link
Member Author

😭 it's Tuesday again and pulling container-images in the CI is problematic...

@nixpanic
Copy link
Member Author

/test ci/centos/mini-e2e-helm/k8s-1.29

1 similar comment
@nixpanic
Copy link
Member Author

/test ci/centos/mini-e2e-helm/k8s-1.29

@nixpanic nixpanic requested a review from a team March 28, 2024 09:38
@nixpanic
Copy link
Member Author

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 28, 2024

rebase

✅ Nothing to do for rebase action

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Mar 28, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Mar 28, 2024
@mergify mergify bot merged commit 3df396e into ceph:devel Mar 28, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@yati1998 yati1998 Awaiting requested review from yati1998

Assignees
No one assigned
Labels
component/rbd Issues related to RBD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nixpanic @ceph-csi-bot @Madhu-1 @yati1998 @iPraveenParihar