Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: free snapshot resources after allocation #4514

Merged
merged 5 commits into from
Mar 28, 2024
Merged

rbd: free snapshot resources after allocation #4514

merged 5 commits into from
Mar 28, 2024

Commits on Mar 26, 2024

  1. cleanup: do not pass an empty snapshot to genSnapFromSnapID() 

    Just like GenVolFromVolID() the genSnapFromSnapID() function can return
a snapshot. There is no need to allocated an empty snapshot and pass
that to the genSnapFromSnapID() function.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ecdbce0 View commit details
    Browse the repository at this point in the history

  2. rbd: free snapshot resources after allocation 

    Not all snapshot objects are free'd correctly after they were allocated.
It is possible that some connections to the Ceph cluster were never
closed. This does not need to be a noticeable problem, as connections
are re-used where possible, but it isn't clean either.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    df0df50 View commit details
    Browse the repository at this point in the history

  3. rbd: let parseVolCreateRequest() return a connected rbdVolume 

    By returning a connected rbdVolume in parseVolCreateRequest(), the
CreateVolume() function can be simplified a little. There is no need to
call the additional Connect() and detect failures with it.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    f4aeef0 View commit details
    Browse the repository at this point in the history

  4. cleanup: reformat generateVolFromSnap() to rbdSnapshot.toVolume() 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    81f11a8 View commit details
    Browse the repository at this point in the history

  5. rbd: add extra logging while cleaning up snapshots 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    93e24a8 View commit details
    Browse the repository at this point in the history