rebase: bump sigs.k8s.io/controller-runtime from 0.17.3 to 0.18.2 in the k8s-dependencies group across 1 directory #4614
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
| err = c.Watch(source.Kind( | ||
| mgr.GetCache(), | ||
| &corev1.PersistentVolume{}, | ||
| handler.TypedEnqueueRequestForOwner[*corev1.PersistentVolume]( |
There was a problem hiding this comment.
should be TypedEnqueueRequestForObject[*corev1.PersistentVolume] ?
There was a problem hiding this comment.
yes thats looks good. updated now.
Madhu-1
force-pushed
the
dependabot/go_modules/k8s-dependencies-b6a9766fde
branch
from
aecdf60
to
18431e4
Compare
|
/test ci/centos/mini-e2e/k8s-1.28 |
Madhu-1
force-pushed
the
dependabot/go_modules/k8s-dependencies-b6a9766fde
branch
from
18431e4
to
84d4b10
Compare
|
/test ci/centos/mini-e2e/k8s-1.28 |
1 similar comment
|
/test ci/centos/mini-e2e/k8s-1.28 |
Bumps the k8s-dependencies group with 1 update in the / directory: [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime). Updates `sigs.k8s.io/controller-runtime` from 0.17.3 to 0.18.2 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.17.3...v0.18.2) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
iPraveenParihar
force-pushed
the
dependabot/go_modules/k8s-dependencies-b6a9766fde
branch
from
84d4b10
to
89c4262
Compare
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
pod describe after But stating path is returned as using image from devel branch (which has I suspect issue with cc @Rakshith-R |
|
replacing, |
iPraveenParihar
force-pushed
the
dependabot/go_modules/k8s-dependencies-b6a9766fde
branch
from
0d058cd
to
e66b90a
Compare
|
/test ci/centos/mini-e2e/k8s-1.28 |
this works!, |
@iPraveenParihar Thank you, lets get it merged and we will revisit mount-utils, lets check what is changed in mount-utils release notes. |
|
few e2e failed at deploy artifats - and few are struct at reserve bare-metal machine and looks weird to me 🤔 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
@iPraveenParihar can you please check on this one. https://jenkins-ceph-csi.apps.ocp.cloud.ci.centos.org/blue/organizations/jenkins/upgrade-tests-rbd/detail/upgrade-tests-rbd/7974/pipeline |
update kubernetes and go version in api folder. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
changes as per new controller runtime import Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
fixing logging as per new controller runtime errors Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Praveen M <m.praveen@ibm.com>
iPraveenParihar
force-pushed
the
dependabot/go_modules/k8s-dependencies-b6a9766fde
branch
from
babe499
to
0af1474
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
mergify
bot
dismissed stale reviews from Rakshith-R and Madhu-1
Pull request has been modified.
updates to vendor/modules.txt were missed during rebase conflicts. |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at a8e9d66 |
dependabot
bot
deleted the
dependabot/go_modules/k8s-dependencies-b6a9766fde
branch
Bumps the k8s-dependencies group with 1 update in the / directory: sigs.k8s.io/controller-runtime.
Updates
sigs.k8s.io/controller-runtimefrom 0.17.3 to 0.18.2Release notes
Sourced from sigs.k8s.io/controller-runtime's releases.
... (truncated)
Commits
834905bMerge pull request #2817 from k8s-infra-cherrypick-robot/cherry-pick-2813-to-...6396a49Reintroduce AddMetricsExtraHandler on managercd2885eMerge pull request #2809 from k8s-infra-cherrypick-robot/cherry-pick-2806-to-...06acde3🐛 correct kind source typed6feaaeMerge pull request #2808 from k8s-infra-cherrypick-robot/cherry-pick-2805-to-...87cae4cbug: Cache: Fix label defaulting of byObject when namespaces are configureded81fa6Merge pull request #2796 from alvaroaleman/markb35cd6b📖 Mark Typed Handlers as experimentalb74908fMerge pull request #2793 from kubernetes-sigs/dependabot/github_actions/actio...a9db208Merge pull request #2794 from kubernetes-sigs/dependabot/github_actions/actio...You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions