ci: add test for uncommitted changes in deploy directory #4759
Conversation
Nikhil-Ladha
force-pushed
the
issue4285/add-code-check
branch
from
5386a80
to
bcfbf52
Compare
nixpanic
added
the
backport-to-release-v3.11
| @@ -72,6 +72,7 @@ queue_rules: | |||
| - "status-success=golangci-lint" | |||
| - "status-success=mod-check" | |||
| - "status-success=lint-extras" | |||
| - "status-success=uncommitted-code-check" | |||
There was a problem hiding this comment.
I see that we are backporting this to release-v3.11 branch, can you please update the mergify rules for the same?
There was a problem hiding this comment.
I don't see a rule for base branch release-v3.11 it is only for all release branches or v3.10 individually.
There was a problem hiding this comment.
https://github.com/ceph/ceph-csi/blob/devel/.mergify.yml#L30, https://github.com/ceph/ceph-csi/blob/devel/.mergify.yml#L177 and https://github.com/ceph/ceph-csi/blob/devel/.mergify.yml#L265, This is applicable for both 3.11 and next 3.12
There was a problem hiding this comment.
If I add it under base~=^(release-.+)$ check, and we only backport to release-v3.11 branch won't that cause the CI in other older branches to fail?
There was a problem hiding this comment.
we are maintaining only 3.10 and 3.11 branches nothing else.
There was a problem hiding this comment.
can you please do it in above 3 places i pointed out?
There was a problem hiding this comment.
Sorry, missed the other places.
Added them now.
Nikhil-Ladha
force-pushed
the
issue4285/add-code-check
branch
from
bcfbf52
to
4aa792c
Compare
Nikhil-Ladha
force-pushed
the
issue4285/add-code-check
branch
from
4aa792c
to
5b1bc9c
Compare
|
@Mergifyio rebase |
added test for uncommitted changes in deploy directory under go-test GH action. Also, created a new make target named `make check-deploy-committed` that can be used to verify the uncommitted changes. Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
nixpanic
force-pushed
the
issue4285/add-code-check
branch
from
5b1bc9c
to
cafc672
Compare
✅ Branch has been successfully rebased |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 71cbf3d |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
Describe what this PR does
Added test for uncommitted changes in deploy directory under go-test GH action. Also, created a new make target named
make check-deploy-committedthat can be used to verify the uncommitted changes.Fixes: #4285
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.