Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add test for uncommitted changes in deploy directory (backport #4759) #4760

Merged
merged 2 commits into from
Aug 14, 2024
Merged

ci: add test for uncommitted changes in deploy directory (backport #4759) #4760

merged 2 commits into from
Aug 14, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 13, 2024

Describe what this PR does

Added test for uncommitted changes in deploy directory under go-test GH action. Also, created a new make target named make check-deploy-committed that can be used to verify the uncommitted changes.

Fixes: #4285

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes
    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
This is an automatic backport of pull request #4759 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Aug 13, 2024
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 13, 2024

Cherry-pick of 71cbf3d has failed:

On branch mergify/bp/release-v3.11/pr-4759
Your branch is up to date with 'origin/release-v3.11'.

You are currently cherry-picking commit 71cbf3d7e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .mergify.yml
	modified:   Makefile

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/go-test.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the component/testing Additional test cases or CI work label Aug 13, 2024
@Nikhil-Ladha @nixpanic
ci: add test for uncommitted changes in deploy directory
6d797fe 
added test for uncommitted changes in deploy directory under go-test GH action.
Also, created a new make target named `make check-deploy-committed` that
can be used to verify the uncommitted changes.

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
(cherry picked from commit 71cbf3d)
@nixpanic nixpanic force-pushed the mergify/bp/release-v3.11/pr-4759 branch from 88a5a67 to 6d797fe Compare August 13, 2024 12:35
nixpanic
nixpanic previously approved these changes Aug 13, 2024
View reviewed changes
@nixpanic nixpanic added ci/skip/e2e skip running e2e CI jobs and removed conflicts labels Aug 13, 2024
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Aug 13, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 13, 2024
Madhu-1
Madhu-1 previously approved these changes Aug 13, 2024
View reviewed changes
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 13, 2024

@nixpanic go-test is failing

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Aug 13, 2024
@mergify mergify bot dismissed stale reviews from Madhu-1 and nixpanic August 13, 2024 13:01

Pull request has been modified.

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 13, 2024
@nixpanic nixpanic requested a review from Madhu-1 August 13, 2024 13:03
@nixpanic
cleanup: remove unneeded comments from modules.txt
21dbc13 
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic nixpanic force-pushed the mergify/bp/release-v3.11/pr-4759 branch from b648cf8 to 21dbc13 Compare August 13, 2024 13:04
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Aug 13, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 13, 2024
@Rakshith-R
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 14, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 0c59f51

@mergify mergify bot merged commit 0c59f51 into release-v3.11 Aug 14, 2024
35 checks passed
@mergify mergify bot deleted the mergify/bp/release-v3.11/pr-4759 branch August 14, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ceph-csi-bot @Madhu-1 @Rakshith-R @nixpanic @Nikhil-Ladha