Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/kill: make username check case-insensitive #43

Merged
merged 1 commit into from
Mar 11, 2024
Merged

services/kill: make username check case-insensitive #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/teuthology_api/services/kill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ def run(args, send_logs: bool, access_token: str, request: Request):
run_name = args.get("--run")
if run_name:
run_details = get_run_details(run_name)
run_username = run_details.get("user")
run_owner = run_details.get("user")
else:
log.error("teuthology-kill is missing --run")
raise HTTPException(status_code=400, detail="--run is a required argument")
# TODO if user has admin priviledge, then they can kill any run/job.
if run_username != username:
if run_owner.lower() != username.lower():
log.error(
"%s doesn't have permission to kill a job scheduled by: %s",
username,
run_username,
run_owner,
)
raise HTTPException(
status_code=401, detail="You don't have permission to kill this run/job"
Expand Down
Loading