Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document new subject ingress/gateway annotations #1244

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

ctrought
Copy link
Contributor

Follow up to add docs for additional ingress/gateway annotations added in v1.12 cert-manager/cert-manager#4502

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2023
@netlify
Copy link

netlify bot commented Jun 12, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit a09d1b2
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/64f6e5aabc631700073f69cf
😎 Deploy Preview https://deploy-preview-1244--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctrought ctrought force-pushed the subject-annotations-docs branch 3 times, most recently from f607ed6 to 6068c7e Compare June 16, 2023 14:26
@inteon inteon self-assigned this Sep 5, 2023
Signed-off-by: Craig Trought <k8s@trought.ca>
@inteon inteon force-pushed the subject-annotations-docs branch from 6068c7e to f6eeae0 Compare September 5, 2023 08:22
@inteon
Copy link
Member

inteon commented Sep 5, 2023

/approve
/lgtm
Thanks for adding documentation for this new feature!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 5, 2023
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon force-pushed the subject-annotations-docs branch from f6eeae0 to a09d1b2 Compare September 5, 2023 08:24
@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 5, 2023
@jetstack-bot jetstack-bot merged commit de0166b into cert-manager:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants