[release-next] Fast-forward master into release-next #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix docs broken link to Venafi OAuth config
Update sentence that was outdated. Signed-off-by: Rafael Tanaka <massaox@gmail.com>
Update approver-policy README.md
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Add release notes for 1.12.1, 1.12.2 and 1.12.3
Signed-off-by: cloudoutloud <39462069+cloudoutloud@users.noreply.github.com>
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
Add release notes for 1.11.2->1.11.4
Ref: cert-manager/cert-manager#6231 Signed-off-by: Maël Valais <mael@vls.dev>
…file Annual review of the OWNERS file (2023): remove Joakim
Signed-off-by: John HU <hszqqq12@gmail.com>
Fix Venafi broken link
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Add docs on trust namespace
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Update supported releases about 1.13
…intainer Ref: cert-manager/cert-manager#6231 Signed-off-by: Maël Valais <mael@vls.dev>
Annual review of the OWNERS file (2023): Maartje moved to Emeritus Maintainer
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Add docs for trust-manager v0.6.0
ref: cert-manager/testing#904 Signed-off-by: Maël Valais <mael@vls.dev>
Renaming all references to jetstack/testing
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Ashley Davis <SgtCoDFish@users.noreply.github.com> Signed-off-by: Erik Godding Boye <egboye@gmail.com>
Add/update docs for new trust-manager features
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Add a concrete example on how to restore a cert-manager installation
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Add FAQ entry on keystore passwords
|
@maelvls: Overrode contexts on behalf of maelvls: dco In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jetstack-bot
added
dco-signoff: no
|
/override dco |
|
@maelvls: Overrode contexts on behalf of maelvls: dco In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/approve |
|
@inteon: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
also adds a little more context Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Add permanent link to keystore passwords
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mael can you force push the master branch to release-next instead? That will prevent a merge commit from being created. |
|
/override dco |
|
@maelvls: Overrode contexts on behalf of maelvls: dco In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
We decided to let the person click "Merge" in the UI instead of waiting for someone to approve to avoid having to ask another person to do this task. See decision in Slack. To be added to the contributor documentation: If you find that the /approve Can someone LGTM? 😅 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
|
/lgtm |
|
@inteon: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Richard agreed that we don't need another dev interaction for merging this kind of PR. I will click "Merge" manually. |
jetstack-bot
added
the
do-not-merge/hold
maelvls
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tanuj needs the release-next branch to be up to date so that he knows where to put the documentation about
nameConstraints./hold
I want to hold Prow from auto-merging this PR we prefer not having needless merge commits when
mastercan be fast-forwarded torelease-next. Once this PR gets approved, I run the following commands:/override dco
I used the command
/override dcois necessary because some the merge commits have been written by the bot and do not have a DCO signoff. The command/override dconeeds to be re-issued every time a commit is merged tomaster.