Link to the official Flux example repo and remove unnecessary --crds flags from example #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See fluxcd/flux2#3009 (comment) Signed-off-by: Richard Wall <richard.wall@venafi.com>
See fluxcd/flux2#3009 (reply in thread) Signed-off-by: Richard Wall <richard.wall@venafi.com>
jetstack-bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hawksight
approved these changes
Nov 9, 2023
|
/lgtm since Peter already reviewed the PR |
|
@inteon |
|
/lgtm |
wallrj
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: hawksight, stefanprodan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-1343--cert-manager-website.netlify.app/docs/installation/continuous-deployment-and-gitops/#using-the-flux-helm-controller
Linked to official Flux example repo
In Deploy cert-manager with Flux fluxcd/flux2#3009 (reply in thread) @stefanprodan wrote:
Removed
--crds CreateReplacebecause cert-manager CRDs do not use the Helmcrds/directory.In Deploy cert-manager with Flux fluxcd/flux2#3009 (reply in thread) @stefanprodan wrote: