Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Peter Fiddes (@hawksight) a reviewer #1346

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Nov 15, 2023

Thanks for all your documentation reviews Peter, for example:

We'd like you to be able to lgtm future PRs,
so we're adding you to the reviewers list.

Thanks for all your documentation reviews Peter, for example:
 * cert-manager#1344
 * cert-manager#1338
 * cert-manager#1331

We'd like you to be able to `lgtm` future PRs,
so we're adding you to the reviewers list.

Signed-off-by: Richard Wall <richard.wall@venafi.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Nov 15, 2023
@wallrj wallrj requested a review from inteon November 15, 2023 17:16
@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2023
Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 2574537
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6554fcf0b301100008cd0225
😎 Deploy Preview https://deploy-preview-1346--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@inteon
Copy link
Member

inteon commented Nov 15, 2023

Welcome 🤗
/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@jetstack-bot jetstack-bot merged commit d1751fb into cert-manager:master Nov 15, 2023
8 checks passed
@wallrj wallrj deleted the make-hawksight-a-reviewer branch November 15, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants