-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain how to install cert-manager using Flux #1338
Conversation
Signed-off-by: Richard Wall <richard.wall@venafi.com>
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@jsoref: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Richard Wall <wallrj@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of suggestions, but LGTM at it stands.
/lgtm
@erikgb: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
content/docs/installation/helm.md
Outdated
[raise an issue](https://github.com/cert-manager/cert-manager/issues) to | ||
discuss. | ||
|
||
|
||
## Install the Helm chart using Flux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we add a separate Flux section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I go to cert-manager.io, I probably would look for a Flux section if that is the tool I'm using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What precisely do you propose?
I did consider adding a flux.md
page, but decided that we'd end up with too many submenu items if we also add argo.md
, anthos.md
, octopus.md
etc.
I also considered that Flux can install cert-manager in other ways too, so it seems appropriate to document the Flux Helm Controller here and in future document the Flex Kustomize controller in the kubectl applyt page.
I looked for examples from other projects and I found that Kyverno have a https://kyverno.io/docs/installation/platform-notes/ page where they include notes for ArgoCD users.
Couldn't find any other examples of projects that have a specific page for installing using flux or argo.
I have tried creating a "Continuous Deployment" page and move this tutorial there.
See what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about the name "GitOps"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's appropriate.
GitOps is about storing your infrastructure configuration in a Git repo and then using a continuous delivery / continuous deployment like Flux tool to apply it.
So this page is about the CD part.
Why do you suggest it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also GitOps is the brand name Red Hat uses on their ArgoCD hybrid, so I would stay FAR away from that term. 😉
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@hawksight: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just ran through the flux installation and it worked perfectly. Thanks @wallrj - a good little intro to fluxcd for me.
Just a question for anyone who knows, did fluxctl
become flux
instead at some point? That tripped me up as I thought I had the CLI but turns out I did not.
/lgtm
@hawksight: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: hawksight The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for all your documentation reviews Peter, for example: * cert-manager#1344 * cert-manager#1338 * cert-manager#1331 We'd like you to be able to `lgtm` future PRs, so we're adding you to the reviewers list. Signed-off-by: Richard Wall <richard.wall@venafi.com>
Thanks for all your documentation reviews Peter, for example: * cert-manager#1344 * cert-manager#1338 * cert-manager#1331 We'd like you to be able to `lgtm` future PRs, so we're adding you to the reviewers list. Signed-off-by: Richard Wall <richard.wall@venafi.com>
Preview: https://deploy-preview-1338--cert-manager-website.netlify.app/docs/installation/helm/#install-the-helm-chart-using-flux
I wanted to see for myself whether cert-manager can be installed using Flux and it seems to be quite straight forward,
so I documented it here.
I used some of the settings -- such as
--crds CreateReplace
-- that @slam-wowx had used in: cert-manager/cert-manager#6409.xref: