Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how to install cert-manager using Flux #1338

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Nov 2, 2023

Preview: https://deploy-preview-1338--cert-manager-website.netlify.app/docs/installation/helm/#install-the-helm-chart-using-flux

I wanted to see for myself whether cert-manager can be installed using Flux and it seems to be quite straight forward,
so I documented it here.

I used some of the settings -- such as --crds CreateReplace -- that @slam-wowx had used in: cert-manager/cert-manager#6409.

xref:

Signed-off-by: Richard Wall <richard.wall@venafi.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Nov 2, 2023
@wallrj wallrj requested a review from hawksight November 2, 2023 15:31
@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 2, 2023
Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit c88984a
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6544e7c51bd8b40008082f2e
😎 Deploy Preview https://deploy-preview-1338--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

content/docs/installation/helm.md Outdated Show resolved Hide resolved
@jetstack-bot
Copy link
Contributor

@jsoref: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Richard Wall <wallrj@users.noreply.github.com>
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of suggestions, but LGTM at it stands.

/lgtm

content/docs/installation/helm.md Outdated Show resolved Hide resolved
content/docs/installation/helm.md Outdated Show resolved Hide resolved
@jetstack-bot
Copy link
Contributor

@erikgb: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Added a couple of suggestions, but LGTM at it stands.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[raise an issue](https://github.com/cert-manager/cert-manager/issues) to
discuss.


## Install the Helm chart using Flux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add a separate Flux section?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I go to cert-manager.io, I probably would look for a Flux section if that is the tool I'm using.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What precisely do you propose?

I did consider adding a flux.md page, but decided that we'd end up with too many submenu items if we also add argo.md, anthos.md, octopus.md etc.

I also considered that Flux can install cert-manager in other ways too, so it seems appropriate to document the Flux Helm Controller here and in future document the Flex Kustomize controller in the kubectl applyt page.

I looked for examples from other projects and I found that Kyverno have a https://kyverno.io/docs/installation/platform-notes/ page where they include notes for ArgoCD users.
Couldn't find any other examples of projects that have a specific page for installing using flux or argo.

I have tried creating a "Continuous Deployment" page and move this tutorial there.
See what you think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about the name "GitOps"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's appropriate.

GitOps is about storing your infrastructure configuration in a Git repo and then using a continuous delivery / continuous deployment like Flux tool to apply it.
So this page is about the CD part.

Why do you suggest it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also GitOps is the brand name Red Hat uses on their ArgoCD hybrid, so I would stay FAR away from that term. 😉

Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2023
@jetstack-bot
Copy link
Contributor

@hawksight: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

I just ran through the flux installation and it worked perfectly. Thanks @wallrj - a good little intro to fluxcd for me.

/lgtm

Just a question for anyone who knows, did fluxctl become flux instead at some point? That tripped me up as I thought I had the CLI but turns out I did not.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@hawksight hawksight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran through the flux installation and it worked perfectly. Thanks @wallrj - a good little intro to fluxcd for me.

Just a question for anyone who knows, did fluxctl become flux instead at some point? That tripped me up as I thought I had the CLI but turns out I did not.

/lgtm

@jetstack-bot
Copy link
Contributor

@hawksight: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

I just ran through the flux installation and it worked perfectly. Thanks @wallrj - a good little intro to fluxcd for me.

Just a question for anyone who knows, did fluxctl become flux instead at some point? That tripped me up as I thought I had the CLI but turns out I did not.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@erikgb
Copy link
Contributor

erikgb commented Nov 5, 2023

Just a question for anyone who knows, did fluxctl become flux instead at some point? That tripped me up as I thought I had the CLI but turns out I did not.

I think fluxctl was the CLI tool for the deprecated Flux v1 - which became flux in the current Flux v2.

@inteon
Copy link
Member

inteon commented Nov 8, 2023

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@wallrj wallrj added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: hawksight

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 1c23844 into cert-manager:master Nov 8, 2023
4 checks passed
wallrj added a commit to wallrj/website that referenced this pull request Nov 15, 2023
Thanks for all your documentation reviews Peter, for example:
 * cert-manager#1344
 * cert-manager#1338
 * cert-manager#1331

We'd like you to be able to `lgtm` future PRs,
so we're adding you to the reviewers list.

Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj wallrj deleted the flux-install branch November 17, 2023 14:46
SgtCoDFish pushed a commit to SgtCoDFish/cert-manager-website that referenced this pull request Jan 18, 2024
Thanks for all your documentation reviews Peter, for example:
 * cert-manager#1344
 * cert-manager#1338
 * cert-manager#1331

We'd like you to be able to `lgtm` future PRs,
so we're adding you to the reviewers list.

Signed-off-by: Richard Wall <richard.wall@venafi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants