Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Small typo on best practice: is should have been us #1342

Merged
merged 2 commits into from
Nov 9, 2023
Merged

docs: Small typo on best practice: is should have been us #1342

merged 2 commits into from
Nov 9, 2023

Conversation

WyriHaximus
Copy link
Contributor

No description provided.

@WyriHaximus
docs: Small typo on best practice: is should have been us
088088d 
Signed-off-by: Cees-Jan Kiewiet <ceesjank@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 9, 2023 •
edited
Loading

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 1c44613
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/654c9c804629040008e744eb
😎 Deploy Preview https://deploy-preview-1342--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2023
@WyriHaximus
docs: Removed some repetition from liveness probe notes
1c44613 
Signed-off-by: Cees-Jan Kiewiet <ceesjank@gmail.com>
@WyriHaximus WyriHaximus force-pushed the docs/installation/best-practice/is-to-us-typo branch from c44d02d to 1c44613 Compare November 9, 2023 08:46
wallrj
wallrj approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WyriHaximus

Out of interest, have you enabled the controller liveness probe in production?
Found any circumstances where the controller has become stuck?

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2023
@jetstack-bot jetstack-bot merged commit d11a620 into cert-manager:master Nov 9, 2023
1 check passed
@WyriHaximus WyriHaximus deleted the docs/installation/best-practice/is-to-us-typo branch November 9, 2023 15:02
@WyriHaximus
Copy link
Contributor Author

Thanks @WyriHaximus

Out of interest, have you enabled the controller liveness probe in production? Found any circumstances where the controller has become stuck?

No problem @wallrj, I was actually surprised to read the liveness prob isn't enabled by default. Just enabled it on my personal clusters. Will discuss it with my team at work tonight, and report any issues we run into.

@jetstack-bot jetstack-bot mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj wallrj approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WyriHaximus @jetstack-bot @wallrj