Only include latest version of docs in sitemap #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
jetstack-bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wallrj
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Thanks Tim.
richard@LAPTOP-HJEQ9V9G:~/projects/cert-manager/website$ curl -sSL https://deploy-preview-1319--cert-manager-website.netlify.app/sitemap-0.xml | wc -l
175
richard@LAPTOP-HJEQ9V9G:~/projects/cert-manager/website$ curl -sSL https://cert-manager.io/sitemap-0.xml | wc -l
1158
$ diff -u <(curl -sSL https://cert-manager.io/sitemap-0.xml | grep -o -P 'https://[^<]+') <(curl -sSL https://deploy-preview-1319--cert-manager-website.netlify.app/sitemap-0.xml | grep -o -P 'https://[^<]+')
...
-https://cert-manager.io/v1.9-docs/cli/
-https://cert-manager.io/v1.9-docs/cli/acmesolver/
-https://cert-manager.io/v1.9-docs/cli/cainjector/
-https://cert-manager.io/v1.9-docs/cli/cmctl/
-https://cert-manager.io/v1.9-docs/cli/controller/
-https://cert-manager.io/v1.9-docs/cli/webhook/
-https://cert-manager.io/v1.9-docs/reference/api-docs/Looks right to me.
Another additional thing we could do in another PR is to configure netlify to add a no-index header to those pages. Similar to what we do to prevent the preview sites being indexed.
Lines 16 to 20 in 2ff494e
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current sitemap contains
/vX.Y-docs/...pages: https://cert-manager.io/sitemap-0.xmlThis PR removes all those docs from the sitemap.
This way, Google will hopefully only show the latest docs.