Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Docs needed Camel case feature gate names #1328

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

hawksight
Copy link
Member

@hawksight hawksight commented Oct 17, 2023

On upgrading to 1.13.1 I tried to use the examples in the documentation. However I got the following errors:

E1017 13:05:38.038480       1 main.go:39] "cert-manager: error executing command" err="failed to set feature gates from initial flags-based config: unrecognized feature gate: experimentalGatewayAPISupport"
E1017 13:08:16.019948       1 main.go:35] "cert-manager: error executing command" err="failed to set feature gates from initial flags-based config: unrecognized feature gate: additionalCertificateOutputFormats"

Tackling this I just needed to capitalise the first letters, which puts the config inline with command like --extraArgs options.

Signed-off-by: Peter Fiddes peter.fiddes@gmail.com

Signed-off-by: Peter Fiddes <peter.fiddes@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit f0af5f6
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/652ea4b5e94124000a5f073b
😎 Deploy Preview https://deploy-preview-1328--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Peter Fiddes <peter.fiddes@gmail.com>
@hawksight
Copy link
Member Author

Quick screenshot of the new:

image

@inteon
Copy link
Member

inteon commented Oct 17, 2023

Thanks @hawksight
/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@jetstack-bot jetstack-bot merged commit 2d1d51c into cert-manager:master Oct 17, 2023
1 check passed
@hawksight hawksight deleted the pf/config-case branch October 17, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants