Add the source of the PNG shown in https://cert-manager.io/docs/concepts/certificate/ #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot to add the source in [1]. Or rather, I had embedded the source inside the PNG file, which is surprising to anyone who wants to make changes to the diagram. As I explained in [2], let's have the source directly checked in Git. [1]: cert-manager#582 [2]: cert-manager#426 Signed-off-by: Maël Valais <mael@vls.dev>
jetstack-bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks a lot |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in 2021, I forgot to add the source in 1. Or rather, I had embedded the source inside the PNG file, which is surprising to anyone who wants to make changes to the diagram. As I explained in 2, let's have the source directly checked in Git.
If you would like to re-generate the PNG file, you have two options:
From the UI:
From the command-line (macOS instructions):
brew install drawionpm i -g tinypngalias drawio=/Applications/draw.io.app/Contents/MacOS/draw.iodrawio -x -f png -o public/images/letsencrypt-flow-cert-manager.png public/images/letsencrypt-flow-cert-manager.drawio --scale 2tinypng -k <token> public/images/letsencrypt-flow-cert-manager.png/cc @inteon