Add FAQ entry on keystore passwords #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
erikgb
reviewed
Dec 1, 2023
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
SgtCoDFish
force-pushed
the
no-jks-passwords
branch
from
7901202 to
d30d336
Compare
inteon
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
/lgtm
Thanks for explaining this @SgtCoDFish.
/hold in case you want someone else to read this too.
jetstack-bot
added
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
|
A huge LGTM from me also. Thanks Ash! I don't have reviewer permissions on this project yet, but I'm planning to create a PR for that. |
|
/unhold Thanks both! |
jetstack-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a hotly requested thing when we've been talking about these passwords for both cert-manager and trust-manager, and it was discussed in the biweekly meeting on 2023-11-30.
Longer term, this FAQ entry should provide us with justification for allowing users to specify these "passwords" in plaintext in their
Certificateresources, replacingpasswordSecretRefon JKSKeystore and PKCS12Keystore.