Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permanent link to keystore passwords #1356

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Add permanent link to keystore passwords #1356

merged 1 commit into from
Dec 7, 2023

Conversation

SgtCoDFish
Copy link
Member

also adds a little more context

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2023
SgtCoDFish
SgtCoDFish commented Dec 7, 2023
View reviewed changes
content/docs/faq/README.md Outdated Show resolved Hide resolved
@netlify Netlify
Copy link

netlify bot commented Dec 7, 2023 •
edited
Loading

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 77589e1
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6571ac333c59000008acaeb4
😎 Deploy Preview https://deploy-preview-1356--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

erikgb
erikgb reviewed Dec 7, 2023
View reviewed changes
content/docs/faq/README.md

- "Why is it OK to hard code these passwords?"
- "Do I need to keep these passwords secure?"
- "Are these passwords used in a secure way?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if I understand this question? WDYM with "secure way"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant like "If I use one of these passwords, is it handled like private data?" - to which we'd answer "you shouldn't care, because they're not helpful" 😂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think the most important is to get this into the docs. 😸

erikgb
erikgb approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Which I am still not eligible to do. 😉

@jetstack-bot
Copy link
Contributor

@erikgb: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Which I am still not eligible to do. 😉

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hawksight
hawksight approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@hawksight hawksight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good addition to me

@SgtCoDFish
add permanent link to keystore passwords
77589e1 
also adds a little more context

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@inteon
Copy link
Member

inteon commented Dec 7, 2023

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, hawksight, inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@jetstack-bot jetstack-bot merged commit 550f1f1 into cert-manager:master Dec 7, 2023
4 checks passed
@jetstack-bot jetstack-bot mentioned this pull request Dec 7, 2023
Merged
@SgtCoDFish SgtCoDFish deleted the passwordsagain branch December 7, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawksight hawksight hawksight approved these changes

@erikgb erikgb erikgb approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SgtCoDFish @jetstack-bot @inteon @erikgb @hawksight