Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Links] Show external-link icon where applicable #768

Merged
merged 21 commits into from
Oct 28, 2024
Merged

[Links] Show external-link icon where applicable #768

merged 21 commits into from
Oct 28, 2024

Commits on Oct 9, 2024

  1. [Links] Show external-link icon where applicable

    @meissadia
    meissadia committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ce2d3b0 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge branch 'main' into external-link-icon

    @meissadia
    meissadia authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d0ab4da View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. feat: [Link] External link - Apply "No wrap" to keep icon with link text

    @meissadia
    meissadia committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    091e658 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into external-link-icon

    @tanner-ricks
    tanner-ricks authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f2b44fe View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. [Bug] InstitutionHeading Pipe Spacing Fix (#1007) 

    Fixed a bug that was causing one space to appear instead of the intended
two.

## Changes

- src
  - pages
    - Filing
      - FilingApp
- InsitutionHeading.tsx: Replaced double spaces with double unicode
non-breaking spaces.

## How to test this PR

1. Pull the branch
2. Relaunch whatever is necessary
3. Navigate to a page in the app that contains the Filing Steps and the
Institution Heading
4. Verify that the pipe character is surrounded by two spaces in the
Institution Heading. The attached screenshot has a red box which
surrounds the area to check.

## Screenshots
![Screenshot 2024-10-17 at 12 27
18 PM](https://github.com/user-attachments/assets/06b50ca5-76fb-4920-849c-47e67e5b1537)
    @tanner-ricks @meissadia
    tanner-ricks authored and meissadia committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e9e6860 View commit details
    Browse the repository at this point in the history

  2. [Point of Contact] Phone Extension - Limit to 9 digits, 0-9 in string (… 

    …#1001)

closes #997

## Changes

- style(Point of Contact): Phone Extension always gets its own line
- content(Point of Contact): Change the helper and error text to match
the figma
- feat(Point of Contact): Phone Extension validation


## How to test this PR

1. Navigate to Point of Contact
2. Enter valid phone extension - ex. 00757
3. Enter invalid phone extension - ex ukhi778ih89h98h9h9h89h

## Screenshots
<img width="534" alt="Screenshot 2024-10-15 at 3 08 40 PM"
src="https://github.com/user-attachments/assets/7ed7bae8-9bc0-489f-9e63-a7748e8b9582">

---------

Co-authored-by: Tanner Ricks <182143365+tanner-ricks@users.noreply.github.com>
    @shindigira @tanner-ricks @meissadia
    2 people authored and meissadia committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    366c321 View commit details
    Browse the repository at this point in the history

  3. fix: [BetaAndLegalNotice] Remove icon from external link border

    @meissadia
    meissadia committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    975cc68 View commit details
    Browse the repository at this point in the history

  4. feat: [Link] Programmatically determine internal vs external links 

    task: [Link] Refactor to simplify implied usage of RouterLink
    @meissadia
    meissadia committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e930993 View commit details
    Browse the repository at this point in the history

  5. task: Ensure all instances of <Link> use the SBL Link

    @meissadia
    meissadia committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    025ae81 View commit details
    Browse the repository at this point in the history

  6. task: [Link] Remove unnecessary passages of the isRouterLink prop

    @meissadia
    meissadia committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4a94695 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into external-link-icon

    @meissadia
    meissadia authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0ceb20a View commit details
    Browse the repository at this point in the history

  8. task: cleanup

    @meissadia
    meissadia committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    925263e View commit details
    Browse the repository at this point in the history

  9. task: Link - Support forced rendering as an external link 

    task: Link - Consider `mailto:` links as internal
    @meissadia
    meissadia committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c913c7c View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Merge branch 'main' into external-link-icon

    @meissadia
    meissadia authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b214cc9 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. fix: [Links] Clarify logic for determining external links based on th… 

    …e link domain.
    @meissadia
    meissadia committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    4626d0f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'external-link-icon' of https://github.com/cfpb/sbl-fron… 

    …tend into external-link-icon
    @meissadia
    meissadia committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ebaeda0 View commit details
    Browse the repository at this point in the history

  3. task: [Link] Clarify comment

    @meissadia
    meissadia committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d7ec93c View commit details
    Browse the repository at this point in the history

  4. task: [Link] Cleanup regex

    @meissadia
    meissadia committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    0a2eca9 View commit details
    Browse the repository at this point in the history

  5. fix: [Filing landing] Underline the email our support staff link

    @meissadia
    meissadia committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    50cdc01 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. feat: [Link] Programmatically determine internal vs external links v2

    @meissadia
    meissadia committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9f3b9ac View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into external-link-icon

    @meissadia
    meissadia authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6e0296f View commit details
    Browse the repository at this point in the history