Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deepEqual fonction to be configured globally #1551

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

forty
Copy link
Contributor

@forty forty commented Nov 10, 2023

Tentative MR to allow configuring the deepEqual function globally, as discussed #1520

I have done things using a "flag", planning for the possibility of customizing the deepEqual function on a per assertion basis (but this is not implemented in this MR).

Please let me know what you think.

@forty forty requested a review from a team as a code owner November 10, 2023 10:37
@forty forty force-pushed the forty/global-custom-comparator branch from 79ab6ed to cf3dd4a Compare November 10, 2023 10:39
@forty
Copy link
Contributor Author

forty commented Nov 16, 2023

Can I/Should I do the same MR on the 4.x branch? I think it would be useful for users (like me 😬 ) which are going to be stuck on this release because of the CommonJS drop

Copy link
Member

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@koddsson koddsson merged commit 843eb8d into chaijs:5.x.x Dec 18, 2023
5 checks passed
@koddsson
Copy link
Member

Can I/Should I do the same MR on the 4.x branch? I think it would be useful for users (like me 😬 ) which are going to be stuck on this release because of the CommonJS drop

Yeah that could be good if you'd like it in the 4.x branch. I'm not sure how much support we can give to the 4.x branch once we release 5.x but we can at least merge PRs and publish the package.

@forty
Copy link
Contributor Author

forty commented Dec 18, 2023

Awesome, thanks for the review & merge! I created the same MR for 4.x.x then #1553 (same diff as far I can can tell, except chai.js)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants