-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow deepEqual fonction to be configured globally (4.x.x branch) #1553
Allow deepEqual fonction to be configured globally (4.x.x branch) #1553
Conversation
Thanks @43081j for the review! Happy new year to the Chai team and congrats on the v5 release 👏 I assume you must be busy handling "after sales" of the release, but do you think this MR could be merged and released any time soon? Thanks! |
Let me see if I can publish this without breaking everything 😅 |
Should be out there now in v4.4.0 |
Awesome, thanks a lot @koddsson ! Everything looks good on my side (and you haven't override the latest tag ;) ) |
Oh but I did for a couple of minutes 😭 |
This broke our CI: deltachat/deltachat-core-rust#5153 Fails with:
CI runs node.js 18.19.0. |
Are you sure of your nodejs version? Nullish Coalescing operator ?? exists since nodejs 14.
|
Ok, I found the issue in your setup standard-things/esm#909 Looks like you are using this "esm" package, which have been dead for a while, last publish was 5 years ago and the repo is archived, so I would not expect a fix 😬 |
Thanks, I filed an issue to track this at deltachat/deltachat-core-rust#5156 |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [chai](http://chaijs.com) ([source](https://github.com/chaijs/chai)) | [`4.3.10` -> `4.4.0`](https://renovatebot.com/diffs/npm/chai/4.3.10/4.4.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/chai/4.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/chai/4.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/chai/4.3.10/4.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/chai/4.3.10/4.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>chaijs/chai (chai)</summary> ### [`v4.4.0`](https://github.com/chaijs/chai/releases/tag/v4.4.0) [Compare Source](https://github.com/chaijs/chai/compare/v4.3.10...v4.4.0) #### What's Changed - Allow deepEqual fonction to be configured globally (4.x.x branch) by [@​forty](https://github.com/forty) in [chaijs/chai#1553 **Full Changelog**: chaijs/chai@v4.3.10...v4.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/erezrokah/aws-testing-library). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [chai](http://chaijs.com) ([source](https://github.com/chaijs/chai)) | devDependencies | minor | [`4.3.10` -> `4.4.0`](https://renovatebot.com/diffs/npm/chai/4.3.10/4.4.0) | --- ### Release Notes <details> <summary>chaijs/chai (chai)</summary> ### [`v4.4.0`](https://github.com/chaijs/chai/releases/tag/v4.4.0) [Compare Source](https://github.com/chaijs/chai/compare/v4.3.10...v4.4.0) #### What's Changed - Allow deepEqual fonction to be configured globally (4.x.x branch) by [@​forty](https://github.com/forty) in [chaijs/chai#1553 **Full Changelog**: chaijs/chai@v4.3.10...v4.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMy4zIiwidXBkYXRlZEluVmVyIjoiMzcuMTMuMyIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
Identical change as #1551 on 4.x.x branch