refactor: move collected network fee to swapping pallet

[j4m1ef0rd]

Pull Request

Closes: PRO-1404

Checklist

Please conduct a thorough self-review before opening the PR.

• I am confident that the code works.
• I have updated documentation where appropriate.

Summary

• Moved the FlipBuyInterval and CollectedNetworkFee storage items from the pools pallet to the swapping pallet.
  • Moved related functions and genesis config item.
  • Moved related tests and benchmarks.
  • Added migration to runtime.
• Changed the pools tests to no longer know anything about a network fee, this changed some of the values from swaps a little (no more network fee).
• Refactored the tests that got moved to the swapping pallet. Might be hard to see the changes because of the move, I can try and split the move into a separate commit, but it didn't seem worth the time unless requested.
• Added the test_fee_estimation_basis test, not sure why it was just stilling as a function description.

[codecov]

Codecov Report

Attention: Patch coverage is 77.43056% with 65 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (6f1c062) to head (d1cef49).

Files	Patch %	Lines
...-chain/runtime/src/migrations/move_network_fees.rs	0%	24 Missing ⚠️
state-chain/pallets/cf-swapping/src/lib.rs	86%	10 Missing and 6 partials ⚠️
state-chain/pallets/cf-swapping/src/weights.rs	0%	16 Missing ⚠️
state-chain/runtime/src/lib.rs	0%	0 Missing and 5 partials ⚠️
state-chain/pallets/cf-swapping/src/mock.rs	25%	3 Missing ⚠️
state-chain/pallets/cf-swapping/src/tests.rs	99%	1 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##            main   #5014    +/-   ##
======================================
- Coverage     72%     71%    -0%     
======================================
  Files        433     434     +1     
  Lines      75474   75254   -220     
  Branches   75474   75254   -220     
======================================
- Hits       53991   53693   -298     
- Misses     18631   18710    +79     
+ Partials    2852    2851     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dandanlen]

LGTM.

Just a minor thing, no need to change this now, but in future please prefer to put the runtime-level migrations in their own modules - makes the diffing/merging much easier when the time comes to remove the migrations after they've passed.

[j4m1ef0rd]

@dandanlen the upgrade test is still failing bouncer. I thought this was fixed. This branch is updated with main.

[dandanlen]

@dandanlen the upgrade test is still failing bouncer. I thought this was fixed. This branch is updated with main.

Yeah I thought it was fixed too... will take a look.

[dandanlen]

It must be something that's in main - this PR is failing the upgrade check too, and it doesn't change any code:
#5033