feat: smart retrier endpoint selection #4984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4984 +/- ##
======================================
Coverage 71% 72%
======================================
Files 429 431 +2
Lines 74082 74791 +709
Branches 74082 74791 +709
======================================
+ Hits 52931 53542 +611
- Misses 18315 18401 +86
- Partials 2836 2848 +12 ☔ View full report in Codecov by Sentry. |
kylezs
force-pushed
the
feat/smart-endpoint-selection
branch
from
b16a660
to
c6183e6
Compare
test: backup used after primary down
kylezs
force-pushed
the
feat/smart-endpoint-selection
branch
from
c6183e6
to
82317f7
Compare
kylezs
changed the title
AlastairHolmes
approved these changes
Jun 26, 2024
AlastairHolmes
approved these changes
Jun 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
* chore: remove unused struct * feat: smart endpoint selection test: backup used after primary down * chore: last tried -> last failed * refactor: invert condition
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
syan095
added a commit
that referenced
this pull request
Jul 23, 2024
…-ccm-checker * origin/wip/solana-api: Feat/solana ccm gas limit (#5048) feat: return early if no client ready on retry limited requests (#5057) feature/PRO-1378/validator-gas-refund (#4962) chore: fix bug in merge that caused tests to fail chore: build binaries on Mac M2 Runner 🍎 (#5005) chore: remove unused spec versioned migration util (#5054) test: update integration tests feat(docker images): add `chainflip-node` probe scripts 🩺 (#5033) Feat: Make FoK constants configurable (#5024) fix: cp .so files to /usr/lib (#5051) chore: run gas_limit test by default fix: allow validators to deregister once they no longer have relevant key material (#5045) Feat: RPC lp total balances (#4951) fix: rpath name on 1.4.5 dylib (#5046) chore: remove cp dylibs from post check (#5044) feat: add primary/secondary label to RPC_RETRIER_TOTAL_REQUESTS metric (#5015) feat: smart retrier endpoint selection (#4984) refactor: move collected network fee to swapping pallet (#5014) feat: consistent broker api address strings (#5030) # Conflicts: # foreign-chains/solana/sol-prim/src/consts.rs # state-chain/chains/src/sol/api.rs # state-chain/pallets/cf-swapping/src/lib.rs # state-chain/pallets/cf-swapping/src/mock.rs # state-chain/runtime/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1409
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
The idea here is that we want to keep trying the secondary endpoint until a specified time (2 minutes) has elapsed. We then try the primary endpoint again to check it's online. If not, we try the backup again. Note that this is global to all requests for the chain - previously every request would start by trying the primary, but not it will try the currently preferred endpoint, and occassionally re-attempt the primary, as we want to bias towards the primary.