-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move collected network fee to swapping pallet #5014
Conversation
25a6574
to
0291412
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5014 +/- ##
======================================
- Coverage 72% 71% -0%
======================================
Files 433 434 +1
Lines 75474 75254 -220
Branches 75474 75254 -220
======================================
- Hits 53991 53693 -298
- Misses 18631 18710 +79
+ Partials 2852 2851 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just a minor thing, no need to change this now, but in future please prefer to put the runtime-level migrations in their own modules - makes the diffing/merging much easier when the time comes to remove the migrations after they've passed.
@dandanlen the upgrade test is still failing bouncer. I thought this was fixed. This branch is updated with main. |
Yeah I thought it was fixed too... will take a look. |
It must be something that's in main - this PR is failing the upgrade check too, and it doesn't change any code: |
…-ccm-checker * origin/wip/solana-api: Feat/solana ccm gas limit (#5048) feat: return early if no client ready on retry limited requests (#5057) feature/PRO-1378/validator-gas-refund (#4962) chore: fix bug in merge that caused tests to fail chore: build binaries on Mac M2 Runner 🍎 (#5005) chore: remove unused spec versioned migration util (#5054) test: update integration tests feat(docker images): add `chainflip-node` probe scripts 🩺 (#5033) Feat: Make FoK constants configurable (#5024) fix: cp .so files to /usr/lib (#5051) chore: run gas_limit test by default fix: allow validators to deregister once they no longer have relevant key material (#5045) Feat: RPC lp total balances (#4951) fix: rpath name on 1.4.5 dylib (#5046) chore: remove cp dylibs from post check (#5044) feat: add primary/secondary label to RPC_RETRIER_TOTAL_REQUESTS metric (#5015) feat: smart retrier endpoint selection (#4984) refactor: move collected network fee to swapping pallet (#5014) feat: consistent broker api address strings (#5030) # Conflicts: # foreign-chains/solana/sol-prim/src/consts.rs # state-chain/chains/src/sol/api.rs # state-chain/pallets/cf-swapping/src/lib.rs # state-chain/pallets/cf-swapping/src/mock.rs # state-chain/runtime/src/lib.rs
Pull Request
Closes: PRO-1404
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
FlipBuyInterval
andCollectedNetworkFee
storage items from the pools pallet to the swapping pallet.test_fee_estimation_basis
test, not sure why it was just stilling as a function description.