Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pallet versions should match release + bump old dylib version to 1.5.1 #5142

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Aug 12, 2024

Pull Request

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Release 1.5.1 has ingress-egress pallet at version 12, so the upgrade was failing, since the storage on-chain was 12, and the one in the new runtime was 11 which is lower.

@kylezs kylezs requested a review from dandanlen as a code owner August 12, 2024 11:23
@kylezs kylezs mentioned this pull request Aug 12, 2024
2 tasks
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71%. Comparing base (8f10dc3) to head (53dc1cf).

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5142    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        460     460            
  Lines      81651   81507   -144     
  Branches   81651   81507   -144     
======================================
- Hits       58166   57963   -203     
- Misses     20390   20443    +53     
- Partials    3095    3101     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs changed the title fix: pallet versions should match release fix: pallet versions should match release + bump old dylib version to 1.5.1 Aug 12, 2024
@kylezs kylezs disabled auto-merge August 12, 2024 11:47
@kylezs kylezs enabled auto-merge August 12, 2024 11:47
@kylezs kylezs added this pull request to the merge queue Aug 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2024
@kylezs kylezs enabled auto-merge August 12, 2024 13:40
@kylezs kylezs added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 52155ff Aug 12, 2024
46 of 47 checks passed
@kylezs kylezs deleted the fix/pallet-versions branch August 12, 2024 14:52
syan095 added a commit that referenced this pull request Aug 12, 2024
…tracker

* origin/main:
  Rename PrimaryOrBackup (#5139)
  feat: Governance extrinsic to recover Solana Durable Nonces (#5130)
  fix: pallet versions should match release + bump old dylib version to 1.5.1 (#5142)

# Conflicts:
#	state-chain/pallets/cf-ingress-egress/src/migrations.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants