feat: Governance extrinsic to recover Solana Durable Nonces #5130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5130 +/- ##
=====================================
- Coverage 71% 71% -0%
=====================================
Files 460 460
Lines 81649 81647 -2
Branches 81649 81647 -2
=====================================
- Hits 58169 58102 -67
- Misses 20390 20442 +52
- Partials 3090 3103 +13 ☔ View full report in Codecov by Sentry. |
albert-llimos
approved these changes
Aug 8, 2024
dandanlen
reviewed
Aug 9, 2024
| #[pallet::call_index(7)] | ||
| // Todo | ||
| #[pallet::weight(Weight::zero())] | ||
| pub fn update_sol_nonce( |
There was a problem hiding this comment.
Just realised there's no benchmark for this...
There was a problem hiding this comment.
Can we please add one, or open an issue to add one (if it doesn't already exist)
There was a problem hiding this comment.
dandanlen
approved these changes
Aug 9, 2024
Comment on lines
+504
to
+509
| .iter() | ||
| .position(|(account, _)|*account == nonce_account) | ||
| .map(|idx| { | ||
| durable_nonces[idx] = (nonce_account, new_hash); | ||
| new_hash | ||
| }) |
There was a problem hiding this comment.
iter_mut is generally a better idea than using indices do update a map mid-iteration (even though I think it's ok here).
durable_nonces
.iter_mut()
.find(|(account, _)|*account == nonce_account)
.map(|(_account, hash)| {
*hash = new_hash;
new_hash
})
.ok_or::<DispatchError>(Error::<T>::NonceAccountNotBeingUsedOrDoesNotExist.into())
ramizhasan111
approved these changes
Aug 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
* Added a new Governance Extrinsic that recovers used DurableNonce * Updated extrinsic docs
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1533
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Added a new Governance Extrinsic that recovers used DurableNonce.
The given Nonce account must be either Available or Unavailable (i.e. New Nonce accounts are not accepted).