Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PrimaryOrBackup #5139

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Rename PrimaryOrBackup #5139

merged 2 commits into from
Aug 12, 2024

Conversation

marcellorigotti
Copy link
Contributor

Pull Request

Closes: PRO-1554

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

  • Renamed Secondary to Backup
  • Added PrimaryOrBackup to the logs when a request fails

Non-Breaking changes

@marcellorigotti marcellorigotti added the non-breaking Merging this PR will create a cherry-pick onto release label Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (270839f) to head (0f3fb6d).

Files Patch % Lines
engine/src/retrier.rs 90% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5139   +/-   ##
=====================================
  Coverage     71%     71%           
=====================================
  Files        460     460           
  Lines      81655   81655           
  Branches   81655   81655           
=====================================
+ Hits       58111   58116    +5     
+ Misses     20445   20444    -1     
+ Partials    3099    3095    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs enabled auto-merge August 12, 2024 07:15
@kylezs kylezs added this pull request to the merge queue Aug 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2024
@kylezs kylezs removed the non-breaking Merging this PR will create a cherry-pick onto release label Aug 12, 2024
@kylezs kylezs added this pull request to the merge queue Aug 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2024
@kylezs kylezs enabled auto-merge August 12, 2024 16:34
@kylezs kylezs added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit f3876fa Aug 12, 2024
48 checks passed
@kylezs kylezs deleted the feature/pro-1554 branch August 12, 2024 17:47
syan095 added a commit that referenced this pull request Aug 12, 2024
…tracker

* origin/main:
  Rename PrimaryOrBackup (#5139)
  feat: Governance extrinsic to recover Solana Durable Nonces (#5130)
  fix: pallet versions should match release + bump old dylib version to 1.5.1 (#5142)

# Conflicts:
#	state-chain/pallets/cf-ingress-egress/src/migrations.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants