-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simple pre-witnessing #4056
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRO-852 Pre-Witnessing: Additionally witness deposits after 1 block of confirmation
There should be a new event for this |
kylezs
changed the title
WIP: feat: pre-witness extrinsic
WIP: feat: simple pre-witnessing
Sep 27, 2023
kylezs
force-pushed
the
feat/pre-witness-extrinsic
branch
from
September 28, 2023 07:23
d3d8450
to
0cce4fb
Compare
Codecov Report
@@ Coverage Diff @@
## main #4056 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 374 376 +2
Lines 59219 59440 +221
Branches 59219 59440 +221
======================================
+ Hits 42506 42525 +19
- Misses 14607 14810 +203
+ Partials 2106 2105 -1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlastairHolmes
approved these changes
Sep 28, 2023
dandanlen
added a commit
that referenced
this pull request
Sep 28, 2023
* feat: minimal pre-witnessing support on SC * refactor: dot deposits adapter * refactor: pull btc deposits into an adapter * feat: btc pre-witnessing chore: fix rebase add action * feat: eth prewitnessing * feat: dot prewitnessing * chore: add logging for all prewitnesers * chore: fix feature flags * chore: get txdata once * chore: one word prewitness * chore: consistent logging names * chore: remove unnecessary shared * chore: pre_witness -> prewitness * refactor: dedup deposit_addresses for eth prewitness * refactor: dedup deposit_addresses safe eth witnessing --------- Co-authored-by: Daniel <daniel@chainflip.io>
This was referenced Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review commit by commit.
Pull Request
Closes: PRO-852
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Introduces simple pre-witnessing. When the prewitness call has been "witnessed" i.e. a super majority have submitted that they've seen it, the SC will emit an event
Prewitnessed
. This event can then be used by LPs to see incoming swaps.NB: Because of re-orgs this is inherently unreliable and should not be trusted blindly. It's possible we prewitness something that is not fully witnessed after the lag safety margin.
The CFE simply submits the prewitness extrinsic, when it sees something, without waiting for the safety margin.