-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: ensure correct process termination in ingress/egress tracker #4101
Conversation
(allows collapsing all tests when not needed)
Codecov Report
@@ Coverage Diff @@
## main #4101 +/- ##
======================================
Coverage 71% 72%
======================================
Files 377 378 +1
Lines 59965 60637 +672
Branches 59965 60637 +672
======================================
+ Hits 42716 43492 +776
+ Misses 15008 14880 -128
- Partials 2241 2265 +24 see 37 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
PRO-868 Ingress Egress Tracker
This will/should be broken down into smaller tickets after we've discussed it. Problem: The swapping app currently has to wait for the CFE witnessing and respective confirmation on the SC, both for ingress, when the user is depositing funds, and for egress, when the user is receiving funds. This duration can be quite long, because of the added safety margins to protect against reorgs. Solution: While the reorg safety is important for the protocol it's not important for the product. We can use the same code that we use in the CFE witnessing to avoid duplicating the work, but instead redirect the results of that. Requirements:
Useful info:
Out of scope:
If you have questions for the product team and what they need, you can reach out to nat |
* origin/main: chore: get gas parameters from statechain event (#4125) Feat: ingress-egress tracking for DOT (#4121) add support for hex encoded amounts on limit order and range order methods in LP API (#4120) feat: bouncer command for submitting runtime upgrades (#4122) Feat: ensure correct process termination in ingress/egress tracker (#4101) feat(custom-rpc): add flip balance to account info (#4119) chore: storage migration delete NextCompatibilityVersion (#4115) chore: delete unneeded function (#4116) # Conflicts: # state-chain/runtime/src/lib.rs
Pull Request
Part of: PRO-868
(addresses a review comment from #4081)
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
The PR is designed to be ready commit-by-commit. Note that first commit just moves code into a different file without changes (I separated it to make reviewing easier).
The main change is to use task_scope to spawn all long-running tasks (I did not bother with the task inside
register_subscription
since a panic there doesn't necessarily need to terminate the entire process, and it seemed non-trivial to get lifetimes work there).