feat: Add version cmd to all bins #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4343 +/- ##
======================================
- Coverage 71% 71% -0%
======================================
Files 393 393
Lines 66818 66667 -151
Branches 66818 66667 -151
======================================
- Hits 47720 47495 -225
- Misses 16672 16742 +70
- Partials 2426 2430 +4 ☔ View full report in Codecov by Sentry. |
|
Here is an update to the docs: |
kylezs
approved these changes
Dec 13, 2023
Comment on lines
26
to
28
| #[clap(long = "eth_ws_endpoint")] | ||
| eth_ws_endpoint: Option<String>, | ||
| #[clap(long = "eth_http_endpoint")] |
There was a problem hiding this comment.
For consistency, in the engine we use .
#[clap(long = "eth.rpc.ws_endpoint")]
pub eth_ws_endpoint: Option<String>,
|
Cheers! will make debugging some issues in the future a bit easier |
msgmaxim
approved these changes
Dec 13, 2023
syan095
added a commit
that referenced
this pull request
Dec 18, 2023
…-timeout * origin/main: feat: end to end network upgrade github action (#4274) feat: spec_version of PR is greater than spec version of current release (#4355) feat: enforce version is greater than release version on PRs to main (#4351) fix: btc witnesser test failing sometimes (#4353) fix: connections can become stale when reconnecting (#4310) chore: add `chainflip-rpc-node` systemd file 🚀 (#4352) feat: API Bins check SC compatibility (#4342) chore: update runtime spec checks ⛓️ (#4349) feat: Add version cmd to all bins (#4343) fix: changelog check 🤫 (#4348) chore: update docker tags 🐳 (#4347) chore: add runtime version check 👀 (#4344) feat: shave fees on ingress (#4335) pick/persa fixes (#4329) feat: track btc fees on success (#4334) ensure we dont create BTC transaction outputs below the bitcoin dust limit (#4340) fix: sweeping before withdrawal (#4337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1040
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
ETH_WS_ENDPOINT->ETH__WS_ENDPOINT. Double underscore is now used, same as the other bins.