feat: enforce version is greater than release version on PRs to main #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4351 +/- ##
=====================================
- Coverage 71% 71% -0%
=====================================
Files 393 393
Lines 66667 66667
Branches 66667 66667
=====================================
- Hits 47496 47493 -3
+ Misses 16743 16742 -1
- Partials 2428 2432 +4 ☔ View full report in Codecov by Sentry. |
kylezs
force-pushed
the
feat/force-version-bump
branch
from
6a14e98
to
d1a2b8a
Compare
kylezs
changed the title
ahasna
approved these changes
Dec 14, 2023
2 tasks
syan095
added a commit
that referenced
this pull request
Dec 18, 2023
…-timeout * origin/main: feat: end to end network upgrade github action (#4274) feat: spec_version of PR is greater than spec version of current release (#4355) feat: enforce version is greater than release version on PRs to main (#4351) fix: btc witnesser test failing sometimes (#4353) fix: connections can become stale when reconnecting (#4310) chore: add `chainflip-rpc-node` systemd file 🚀 (#4352) feat: API Bins check SC compatibility (#4342) chore: update runtime spec checks ⛓️ (#4349) feat: Add version cmd to all bins (#4343) fix: changelog check 🤫 (#4348) chore: update docker tags 🐳 (#4347) chore: add runtime version check 👀 (#4344) feat: shave fees on ingress (#4335) pick/persa fixes (#4329) feat: track btc fees on success (#4334) ensure we dont create BTC transaction outputs below the bitcoin dust limit (#4340) fix: sweeping before withdrawal (#4337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Part of: PRO-973
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
In order for the automated upgrade testing to work, we need to ensure that the versions are updated correctly, so that the correct type of upgrade (CFEs required to run side by side) or it's just a runtime upgrade, can be run.
Enforcing that the version is bumped does two things:
NOTE: This does NOT mean that every PR needs to bump the version. The PR simply has to have versions greater than the version currently released. Thus, if an earlier PR has already bumped the release version to be greater than the current release version, then this check will pass.